From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26141 invoked by alias); 27 Apr 2012 07:25:56 -0000 Received: (qmail 26046 invoked by uid 22791); 27 Apr 2012 07:25:54 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 07:25:37 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3R7PbFs025205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 27 Apr 2012 03:25:37 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3R7PUon025348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 27 Apr 2012 03:25:36 -0400 Date: Fri, 27 Apr 2012 10:14:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [3/10] introduce psymtab users Message-ID: <20120427072530.GA1289@host2.jankratochvil.net> References: <87haw7brks.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87haw7brks.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00977.txt.bz2 On Wed, 25 Apr 2012 20:21:23 +0200, Tom Tromey wrote: [...] > + struct partial_symtab **users; [...] > @@ -760,6 +769,11 @@ lookup_partial_symbol (struct partial_symtab *pst, const char *name, > static struct symtab * > psymtab_to_symtab (struct partial_symtab *pst) > { > + /* If it is a shared psymtab, find an unshared psymtab that includes > + it. Any such psymtab will do. */ > + while (pst->users != NULL) > + pst = pst->users[0]; Currently pst->users is used in the whole patchset only for 'pst->users == NULL', 'pst->users != NULL' and for 'pst->users[0]'. I think the array can be dropped. Thanks, Jan