From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21384 invoked by alias); 27 Apr 2012 07:11:41 -0000 Received: (qmail 21375 invoked by uid 22791); 27 Apr 2012 07:11:40 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 07:11:24 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3R7BBlT014700 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Apr 2012 03:11:11 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3R7B6BJ020402 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 27 Apr 2012 03:11:09 -0400 Date: Fri, 27 Apr 2012 07:25:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Mike Frysinger , Will Deacon , "gdb-patches@sourceware.org" Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h Message-ID: <20120427071106.GA30469@host2.jankratochvil.net> References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> <20120426183335.GD20186@mudshark.cambridge.arm.com> <4F99986D.3090305@redhat.com> <201204261505.53852.vapier@gentoo.org> <4F99A002.9020807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F99A002.9020807@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00976.txt.bz2 On Thu, 26 Apr 2012 21:20:34 +0200, Pedro Alves wrote: > Indeed. I've now peeked at strace's sources, and they do some butt-ugly > #ifdef'ery to pick sys/ptrace.h vs asm/ptrace.h depending on arch x libc. > So fine with me to forget about including the header at the top, until we > find some other need. in http://sourceware.org/systemtap/wiki/utrace/tests the ptrace.h inclusion compatible back to RHEL-4 and across x86*/ppc*/s390*/ia64 ended up as: #ifdef __ia64__ #define ia64_fpreg ia64_fpreg_DISABLE #define pt_all_user_regs pt_all_user_regs_DISABLE #endif /* __ia64__ */ #include #ifdef __ia64__ #undef ia64_fpreg #undef pt_all_user_regs #endif /* __ia64__ */ #include #include #include #if defined __i386__ || defined __x86_64__ #include #endif It may be partially unrelated as there were needed more symbols than in gdbserver, OTOH it does not have to solve non-Linux platforms. Regards, Jan