From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16279 invoked by alias); 26 Apr 2012 19:26:33 -0000 Received: (qmail 16270 invoked by uid 22791); 26 Apr 2012 19:26:31 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 19:26:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QJQFLZ001468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 15:26:15 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QJQCpZ017394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Apr 2012 15:26:14 -0400 Date: Thu, 26 Apr 2012 19:29:00 -0000 From: Jan Kratochvil To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] microMIPS support Message-ID: <20120426192611.GA24056@host2.jankratochvil.net> References: <20120426183713.GA21029@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00959.txt.bz2 On Thu, 26 Apr 2012 21:03:35 +0200, Maciej W. Rozycki wrote: > > static const char *const mips_compression_strings[] = { > > Hmm, no objection to your suggestion per se, but is it allowed by C89? It is already used in GDB since: http://sourceware.org/ml/gdb-patches/2012-01/msg00973.html [obv] Code cleanup: add_setshow_enum_cmd: Make 1440 bytes of data segment read-only I am not aware of any compatibility issue of it. Thanks, Jan