From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22322 invoked by alias); 26 Apr 2012 18:36:55 -0000 Received: (qmail 22266 invoked by uid 22791); 26 Apr 2012 18:36:54 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 18:36:42 +0000 Received: from mudshark.cambridge.arm.com (mudshark.cambridge.arm.com [10.1.79.58]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id q3QIabOK022335; Thu, 26 Apr 2012 19:36:37 +0100 (BST) Date: Thu, 26 Apr 2012 18:37:00 -0000 From: Will Deacon To: Mike Frysinger Cc: "gdb-patches@sourceware.org" , "palves@redhat.com" Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h Message-ID: <20120426183636.GE20186@mudshark.cambridge.arm.com> References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> <201204261412.33446.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201204261412.33446.vapier@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00948.txt.bz2 Hi Mike, On Thu, Apr 26, 2012 at 07:12:31PM +0100, Mike Frysinger wrote: > On Thursday 26 April 2012 14:03:00 Will Deacon wrote: > > +/* PTRACE_TEXT_ADDR and friends. */ > > +#include > > check for asm/ptrace.h in configure.ac and then just depend on > HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is realistically > the only C library being used with no-mmu Linux systems. I'll see how Pedro gets on with the unconditional include first. > > #if defined(__UCLIBC__) && defined(HAS_NOMMU) > > +#if !(defined(PT_TEXT_ADDR) || \ > > + defined(PT_DATA_ADDR) || \ > > + defined(PT_TEXT_END_ADDR)) > > i think the GNU way is to have the || at the start of line rather than end, > and a space before the "(" (although i can see that rule isn't completely > honored in this file). Thanks, will fix. Will