From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2470 invoked by alias); 26 Apr 2012 18:34:02 -0000 Received: (qmail 2455 invoked by uid 22791); 26 Apr 2012 18:34:00 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 18:33:48 +0000 Received: from mudshark.cambridge.arm.com (mudshark.cambridge.arm.com [10.1.79.58]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id q3QIXaOK022311; Thu, 26 Apr 2012 19:33:36 +0100 (BST) Date: Thu, 26 Apr 2012 18:36:00 -0000 From: Will Deacon To: Pedro Alves Cc: Mike Frysinger , "gdb-patches@sourceware.org" Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h Message-ID: <20120426183335.GD20186@mudshark.cambridge.arm.com> References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> <201204261412.33446.vapier@gentoo.org> <4F9990A3.6030905@redhat.com> <201204261427.46580.vapier@gentoo.org> <4F999469.10406@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F999469.10406@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00947.txt.bz2 On Thu, Apr 26, 2012 at 07:31:05PM +0100, Pedro Alves wrote: > On 04/26/2012 07:27 PM, Mike Frysinger wrote: > > > On Thursday 26 April 2012 14:14:59 Pedro Alves wrote: > >> On 04/26/2012 07:12 PM, Mike Frysinger wrote: > >>> On Thursday 26 April 2012 14:03:00 Will Deacon wrote: > >>>>> +/* PTRACE_TEXT_ADDR and friends. */ > >>>>> +#include > >>> > >>> check for asm/ptrace.h in configure.ac and then just depend on > >>> HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is > >>> realistically the only C library being used with no-mmu Linux systems. > >> > >> Was there a time Linux didn't have this header? When we include it GDB, we > >> include it unconditionally (though we don't include it in all ports), and > >> in current mainline, it seems that all 27 ports under arch/ have it. > > > > it's not so much a matter of whether it's provided, but whether it can be > > safely included. ia64 has a history of being a pita to include their ptrace > > headers, but maybe that doesn't matter to gdbserver. > > > There are ia64 boxes on the gcc compile farm. Let me give that a try. The ordering of includes probably also comes into play here. I guess we want: "linux-ptrace.h" and then we hope they all play nicely together with their own namespaces. Will