From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2995 invoked by alias); 26 Apr 2012 16:09:49 -0000 Received: (qmail 2942 invoked by uid 22791); 26 Apr 2012 16:09:47 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 16:09:31 +0000 Received: from mudshark.cambridge.arm.com (mudshark.cambridge.arm.com [10.1.79.58]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id q3QG9SOK020283; Thu, 26 Apr 2012 17:09:28 +0100 (BST) Date: Thu, 26 Apr 2012 16:10:00 -0000 From: Will Deacon To: Pedro Alves Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h Message-ID: <20120426160926.GA20186@mudshark.cambridge.arm.com> References: <1335455675-1453-1-git-send-email-will.deacon@arm.com> <4F99718A.2090703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F99718A.2090703@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00930.txt.bz2 On Thu, Apr 26, 2012 at 05:02:18PM +0100, Pedro Alves wrote: > On 04/26/2012 04:54 PM, Will Deacon wrote: > > > > diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c > > index 35d7e69..93d1f36 100644 > > --- a/gdb/gdbserver/linux-low.c > > +++ b/gdb/gdbserver/linux-low.c > > @@ -4772,6 +4772,8 @@ linux_stopped_data_address (void) > > #define PT_TEXT_ADDR (0x10000*4) > > #define PT_DATA_ADDR (0x10004*4) > > #define PT_TEXT_END_ADDR (0x10008*4) > > +#else > > +#include > > #endif > > > I'd much rather we include asm/ptrace.h unconditionally at the top, and wrap the > existing #defines in (a single) #ifndef PT_TEXT_ADDR. That'll allow easily trimming > that section in a few years time, if/when we bump the minimum kernel version > required past a version that is known to define those for those archs. If that breaks > one of those archs, we'll hear about it soon enough, don't sweat about it. :-) Right-o. I did actually try that initially but it gets fairly ugly if you want to deal with the case where only a subset of the #defines exist in the header. If breaking these archs isn't a big concern up-front, then I'm happy just to test PT_TEXT_ADDR for each of them and be done with it. Plus, that should take care of the sane configurations. Will