From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7842 invoked by alias); 26 Apr 2012 19:04:46 -0000 Received: (qmail 7833 invoked by uid 22791); 26 Apr 2012 19:04:46 -0000 X-SWARE-Spam-Status: No, hits=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 19:04:07 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 6F7A71B4036; Thu, 26 Apr 2012 19:04:05 +0000 (UTC) From: Mike Frysinger To: Pedro Alves Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h Date: Thu, 26 Apr 2012 19:06:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.4.0-rc1; KDE/4.6.5; x86_64; ; ) Cc: Will Deacon , "gdb-patches@sourceware.org" References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> <20120426183335.GD20186@mudshark.cambridge.arm.com> <4F99986D.3090305@redhat.com> In-Reply-To: <4F99986D.3090305@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1632817.mDs47FiYAv"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201204261505.53852.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00956.txt.bz2 --nextPart1632817.mDs47FiYAv Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Content-length: 3860 On Thursday 26 April 2012 14:48:13 Pedro Alves wrote: > On 04/26/2012 07:33 PM, Will Deacon wrote: > > On Thu, Apr 26, 2012 at 07:31:05PM +0100, Pedro Alves wrote: > >> On 04/26/2012 07:27 PM, Mike Frysinger wrote: > >>> On Thursday 26 April 2012 14:14:59 Pedro Alves wrote: > >>>> On 04/26/2012 07:12 PM, Mike Frysinger wrote: > >>>>> On Thursday 26 April 2012 14:03:00 Will Deacon wrote: > >>>>>>> +/* PTRACE_TEXT_ADDR and friends. */ > >>>>>>> +#include > >>>>>=20 > >>>>> check for asm/ptrace.h in configure.ac and then just depend on > >>>>> HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is > >>>>> realistically the only C library being used with no-mmu Linux > >>>>> systems. > >>>>=20 > >>>> Was there a time Linux didn't have this header? When we include it > >>>> GDB, we include it unconditionally (though we don't include it in all > >>>> ports), and in current mainline, it seems that all 27 ports under > >>>> arch/ have it. > >>>=20 > >>> it's not so much a matter of whether it's provided, but whether it can > >>> be safely included. ia64 has a history of being a pita to include > >>> their ptrace headers, but maybe that doesn't matter to gdbserver. > >>=20 > >> There are ia64 boxes on the gcc compile farm. Let me give that a try. > >=20 > > The ordering of includes probably also comes into play here. I guess we > > want: > >=20 > > > > > > "linux-ptrace.h" > >=20 > > and then we hope they all play nicely together with their own namespace= s. >=20 > Bah, they don't... Before sys/ptrace.h. >=20 > gcc -c -g3 -O0 -I. -I../../../src/gdb/gdbserver > -I../../../src/gdb/gdbserver/../common > -I../../../src/gdb/gdbserver/../regformats > -I../../../src/gdb/gdbserver/../../include -Wall > -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral > -Wno-char-subscripts -Werror ../../../src/gdb/gdbserver/linux-low.c In > file included from /usr/include/asm/ptrace.h:58, > from ../../../src/gdb/gdbserver/linux-low.c:27: > /usr/include/asm/fpu.h:57: error: redefinition of =91struct ia64_fpreg=92 > In file included from ../../../src/gdb/gdbserver/linux-low.c:28: > /usr/include/sys/ptrace.h:75: error: expected identifier before numeric > constant /usr/include/sys/ptrace.h:117: error: redefinition of =91struct > pt_all_user_regs=92 ../../../src/gdb/gdbserver/linux-low.c: In function > =91linux_attach_lwp_1=92: ../../../src/gdb/gdbserver/linux-low.c:669: err= or: > =91PTRACE_ATTACH=92 undeclared (first use in this function) > ../../../src/gdb/gdbserver/linux-low.c:669: error: (Each undeclared > identifier is reported only once > ../../../src/gdb/gdbserver/linux-low.c:669: error: for each function it > appears in.) ../../../src/gdb/gdbserver/linux-low.c: In function > =91linux_detach_one_lwp=92: ../../../src/gdb/gdbserver/linux-low.c:1139: > error: =91PTRACE_DETACH=92 undeclared (first use in this function) make: = *** > [linux-low.o] Error 1 >=20 > After sys/ptrace.h. >=20 > gcc -c -g3 -O0 -I. -I../../../src/gdb/gdbserver > -I../../../src/gdb/gdbserver/../common > -I../../../src/gdb/gdbserver/../regformats > -I../../../src/gdb/gdbserver/../../include -Wall > -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral > -Wno-char-subscripts -Werror ../../../src/gdb/gdbserver/linux-low.c In > file included from /usr/include/asm/ptrace.h:58, > from ../../../src/gdb/gdbserver/linux-low.c:28: > /usr/include/asm/fpu.h:57: error: redefinition of =91struct ia64_fpreg=92 > In file included from ../../../src/gdb/gdbserver/linux-low.c:28: > /usr/include/asm/ptrace.h:208: error: redefinition of =91struct > pt_all_user_regs=92 make: *** [linux-low.o] Error 1 yes, now you see the pain that ia64 inflicts upon thee! seems ia64-linux-nat.c skips asm/ptrace.h and goes just for asm/ptrace- offsets.h -mike --nextPart1632817.mDs47FiYAv Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPmZyRAAoJEEFjO5/oN/WBiLgP/je3UPanW+Keupp5UOo1M2vn /dKkMpm+c9TaPIWkl8SeWudLvsP6uG8tBHELf6dvsMDFkkRbcynMqaRAjcIsuMNs 3+Q2fiUSclaCdZoC46U96MRlelEw84kSc1La/OzTsRxS7C/yfZdkN/4J4rxTUXRs GjuWFdtz6ih/8w2bA53viKBcJ4McHjvU1yz6i/TrCOXBcY5ntWCkJfF3Y3HkJ9e7 /acm6pDVqGKiZMCQ3IjiBd6/1bpmVsmDGwhHdl6qtgq3TL0ndKIIfx1Qj+etOn5V akfHYehKmjHZ32nkqvD9xUDTFqp1stLI0Ylovexu6PKFLaj2UIl/rCmmxlTIgsEV lezK7WgoExBCFKHlLaDCU8b27Jhnkh01OtQeFmyerkCAauU6/DwqX9OVwWHgbWCV wBZihIPSdsWKUZGnoreGtr7CjciCr/+Ia60paCAxq0ad8TH3EQT6888Jbcq+4Y2Z bXEezmPzd4VRM1EQo/C9Y4B2UmpblO3jOeHEKd9y0vlkBOieVPywKar/zDIcDNPE zYN/sX7m4R5L+1Boz8acOYRebEALz5WOxOBJeCs7I8F8G4QsU1FWB/LAH7FQrxIv elE3VlNnhyCBIEexiidaADJQI6YzP3LMcHn91Ve4BCaiWKN3j4qmGrsBS2OEwQm4 U1vUdtLyd+pSVnHicoKp =WyZ+ -----END PGP SIGNATURE----- --nextPart1632817.mDs47FiYAv--