From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26030 invoked by alias); 26 Apr 2012 14:43:18 -0000 Received: (qmail 26013 invoked by uid 22791); 26 Apr 2012 14:43:16 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 14:43:05 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QEgp2j030665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 10:42:51 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3QEgoWR005921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 26 Apr 2012 10:42:50 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id q3QEgnf2024214; Thu, 26 Apr 2012 16:42:49 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id q3QEgmQl024213; Thu, 26 Apr 2012 16:42:48 +0200 Date: Thu, 26 Apr 2012 15:04:00 -0000 From: Jakub Jelinek To: Tom Tromey Cc: DJ Delorie , Doug Evans , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: RFA: consolidate DWARF strings into libiberty Message-ID: <20120426144248.GA16117@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <87d38dbtal.fsf@fleche.redhat.com> <201203151848.q2FImnAq004284__18018.6977530413$1331837385$gmane$org@greed.delorie.com> <871uotbscq.fsf@fleche.redhat.com> <201203191613.q2JGCx5m011858__41727.2307830446$1332173667$gmane$org@greed.delorie.com> <87obrsmrma.fsf__45145.0892644518$1332177916$gmane$org@fleche.redhat.com> <87fwcqndx8.fsf@fleche.redhat.com> <87limadll4.fsf@fleche.redhat.com> <87d37bwgq1.fsf__11149.6676145636$1334346880$gmane$org@fleche.redhat.com> <87ipgqfqwx.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ipgqfqwx.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00912.txt.bz2 On Mon, Apr 23, 2012 at 08:45:18AM -0600, Tom Tromey wrote: > Tom> Here is a new patch for gcc. > Tom> I still haven't updated the src side, but there's little to do there > Tom> that isn't already done in this patch. > > Tom> Ok? > > Tom> Ping. > > Tom> Ping. > > This is the third ping. > > Please review the patch. > > There are two choices: > > 1. Approve the original patch, adding a file to libiberty. > Given how much code in libiberty is already unrelated to portability, > I would say this is the simplest route. > From a quick glance -- concat.c, the demangler, crc32.c, > dyn-string.c, fdmatch.c, fibheap.c, hashtab.c, hex.c, md5.c, > objalloc.c, obstack.c, sha1.c, simple-object*. Yeah, that would be my preference. libiberty is already a kitchen sink, has been handled that way for many years, and creating a new kitchen sink library is both overkill and will not make it a kitchen sink if only this dwarf strings stuff is added to that and all the other kitchen sink stuff stays in libiberty. Jakub