From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15641 invoked by alias); 26 Apr 2012 18:11:00 -0000 Received: (qmail 15628 invoked by uid 22791); 26 Apr 2012 18:10:58 -0000 X-SWARE-Spam-Status: No, hits=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 18:10:45 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 64A4D1B4033; Thu, 26 Apr 2012 18:10:45 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h Date: Thu, 26 Apr 2012 18:15:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.4.0-rc1; KDE/4.6.5; x86_64; ; ) Cc: Will Deacon , palves@redhat.com References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> In-Reply-To: <1335463380-7288-1-git-send-email-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1650537.sZNdyWAxYP"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201204261412.33446.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00940.txt.bz2 --nextPart1650537.sZNdyWAxYP Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 673 On Thursday 26 April 2012 14:03:00 Will Deacon wrote: > +/* PTRACE_TEXT_ADDR and friends. */ > +#include check for asm/ptrace.h in configure.ac and then just depend on=20 HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is realisticall= y=20 the only C library being used with no-mmu Linux systems. > #if defined(__UCLIBC__) && defined(HAS_NOMMU) > +#if !(defined(PT_TEXT_ADDR) || \ > + defined(PT_DATA_ADDR) || \ > + defined(PT_TEXT_END_ADDR)) i think the GNU way is to have the || at the start of line rather than end,= =20 and a space before the "(" (although i can see that rule isn't completely=20 honored in this file). -mike --nextPart1650537.sZNdyWAxYP Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPmZARAAoJEEFjO5/oN/WBUW8QALpd3JvdtDkJIz6HVkl+r5vZ +w5JAwYnFW746BqDHjO+i4YQxxJkZdl1lv1HhhCOkOivcjxZoTRnBbqvQGdNxrmo zBTPWFm1MYGLE5iCdLPS0ovz4rsgxaaL8fCxla94KuVCon9WK2oYVE+W4WqoX1we teldYzWjiWULh1lSsks/0sDcGoTakrKtw+o60+/W8kqESKIS69+1dfAhp9qFQeyK mWkUOGkU3pHgrc7mmfNkbEyxjbrqeFJv6wch6IE7Z/lXOXwFBmozAF80nNUcVvyK A+wejUhJaeyzY0Vjd4NEak3VZaDc/sa1TFH8ps3BiFnG5js9V5+rcnfIVkJoTePI g/eX2Uv/frUw4Gja8zwxNou5dfOJ510aB4TeZzqb8zP21VGH0Rj0qq8iViE9rlT9 1KrwTU/CioD1jGwbv8miB7VAxff7fIlCkbajbG7LPP2rmL6tJP1fXNL41siRDt/8 U+Wi2/BWwRk/SzByWJ4blAdGwJRGoNXjkynCso0vZDKiCstxl3Rn7viX+FtPsRAu X8BmO81gF1PJrZdC+G61mnUCeSytLmHQszb/7zzRdsGoH3Gaffo+jSEWwuAQQ6/t m9dADIEGi+948toIKWq20+XbAvXHKZl3uWlebg/G+9QPQPW2VXOGv4+KpDaMYeIa pQBdZI7zshSHQL/FUyzu =bOTx -----END PGP SIGNATURE----- --nextPart1650537.sZNdyWAxYP--