From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3208 invoked by alias); 20 Apr 2012 12:43:33 -0000 Received: (qmail 3198 invoked by uid 22791); 20 Apr 2012 12:43:31 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Apr 2012 12:43:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E56CF1C6E45; Fri, 20 Apr 2012 08:43:18 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id t5lczTnmkb3j; Fri, 20 Apr 2012 08:43:18 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 924501C6E40; Fri, 20 Apr 2012 08:43:18 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2117A145616; Fri, 20 Apr 2012 05:43:06 -0700 (PDT) Date: Fri, 20 Apr 2012 12:54:00 -0000 From: Joel Brobecker To: Jeff Kenton Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/2: gdb) Message-ID: <20120420124306.GJ2852@adacore.com> References: <4F906647.8090303@tilera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F906647.8090303@tilera.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00674.txt.bz2 Hello Jeff, I agree on all of Yao's points. In addition, I would split your patches differently: I'd have one patch that adds support to GDB, and then another that adds support to GDBserver. I don't think it makes sense to have one patch with configury/Makefile changes on the one hand, because those changes do not make sense without the associated sources. If you need to be started on the copyright assignment, please let me know, and I will send you the form. -- Joel