From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8676 invoked by alias); 20 Apr 2012 02:46:51 -0000 Received: (qmail 8663 invoked by uid 22791); 20 Apr 2012 02:46:50 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Apr 2012 02:46:34 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3K2kVmn002403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Apr 2012 22:46:31 -0400 Received: from spoyarek (vpn-226-59.phx2.redhat.com [10.3.226.59]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3K2kSxG007027; Thu, 19 Apr 2012 22:46:29 -0400 Date: Fri, 20 Apr 2012 04:23:00 -0000 From: Siddhesh Poyarekar To: "Ulrich Weigand" Cc: jan.kratochvil@redhat.com (Jan Kratochvil), tromey@redhat.com (Tom Tromey), gdb-patches@sourceware.org Subject: Re: [commit] [PATCH] Allow 64-bit enum values Message-ID: <20120420081720.4167fb93@spoyarek> In-Reply-To: <201204191638.q3JGc7YI008735@d06av02.portsmouth.uk.ibm.com> References: <20120418065627.GA31851@host2.jankratochvil.net> <201204191638.q3JGc7YI008735@d06av02.portsmouth.uk.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00656.txt.bz2 On Thu, 19 Apr 2012 18:38:07 +0200 (CEST), Ulrich wrote: > This causes a build failure for me due to: > py-type.c: In function 'convert_field': > py-type.c:186: warning: passing argument 2 of > 'PyObject_SetAttrString' discards qualifiers from pointer target type > > /usr/include/python2.4/object.h has > PyAPI_FUNC(int) PyObject_SetAttrString(PyObject *, char *, > PyObject *); > > Maybe this depends on the Python version? Yes it does. Python 2.7 defines it as: PyAPI_FUNC(int) PyObject_SetAttrString(PyObject *, const char *, PyObject *); I think you should be able to patch that header safely. I can't see a reason to modify an attribute string and I'm pretty sure that it does not. -- Siddhesh