From: Joel Brobecker <brobecker@adacore.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: New ARI warning Fri Apr 20 01:58:17 UTC 2012
Date: Fri, 20 Apr 2012 09:48:00 -0000 [thread overview]
Message-ID: <20120420043807.GI2852@adacore.com> (raw)
In-Reply-To: <4F90C4F7.10302@codesourcery.com>
> IIUC, these alarms are moved from vec.[ch] to common/vec.[ch], so they
> can be ignored. Let me know if I am wrong.
Generally speaking, if there are only a few, I personally think
that we should at least try to address them, especially if it is
easy. But that shouldn't necessarily have to be addressed by
the person who moved the code.
In this particular case, I kind of agree with the warning, but
at the same time, I don't really see why we should necessarily
ban the use of the "inline" keyword. I'm actually considering
the idea of getting rid of this ARI rule.
Any opinion on this topic? My tendency is to discourage the use
of that keyword unless it has been shown to make a difference.
But it's only based on what more experienced engineers have
told me, and I never really had the need to verify it.
--
Joel
next prev parent reply other threads:[~2012-04-20 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 2:07 GDB Administrator
2012-04-20 2:45 ` Yao Qi
2012-04-20 9:48 ` Joel Brobecker [this message]
2012-04-20 10:04 ` Eli Zaretskii
2012-04-20 11:14 ` Pierre Muller
[not found] ` <43835.7730432928$1334919059@news.gmane.org>
2012-04-20 12:41 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420043807.GI2852@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox