From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13416 invoked by alias); 18 Apr 2012 15:41:29 -0000 Received: (qmail 13236 invoked by uid 22791); 18 Apr 2012 15:41:25 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 15:41:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3IFekVS030247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 18 Apr 2012 11:40:46 -0400 Received: from host2.jankratochvil.net (ovpn-116-78.ams2.redhat.com [10.36.116.78]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3IFefMS006023 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 18 Apr 2012 11:40:44 -0400 Date: Wed, 18 Apr 2012 15:52:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Joel Brobecker , Yao Qi , gdb-patches@sourceware.org Subject: Re: Fix in-src-tree builds by making gdbserver/gnulib/ a separate library (a la libiberty, etc.), and adding ACX_CONFIGURE_DIR. Message-ID: <20120418154041.GA17262@host2.jankratochvil.net> References: <20120417170521.GA9906@host2.jankratochvil.net> <4F8DA538.1060000@redhat.com> <20120417232552.GS2852@adacore.com> <4F8E860F.8050906@redhat.com> <20120418092859.GA5887@host2.jankratochvil.net> <4F8E949E.1000702@redhat.com> <20120418123254.GA11744@host2.jankratochvil.net> <4F8EB632.6050501@redhat.com> <20120418125144.GA12372@host2.jankratochvil.net> <4F8EBBA6.10507@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F8EBBA6.10507@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00589.txt.bz2 On Wed, 18 Apr 2012 15:03:34 +0200, Pedro Alves wrote: > On 04/18/2012 01:51 PM, Jan Kratochvil wrote: > > > On Wed, 18 Apr 2012 14:40:18 +0200, Pedro Alves wrote: > >> > This is no different from src/gdb/ vs build/gdb. > > I (and I guess most of the users) always use just in-src-tree-build with src/ > > and no separate build/ . > > Eh. Why would you prefer doing things that way? This is offtopic but: After 6 years I still have not figured out a single reason why to do out-of-src-tree build. It is difficult to switch directories back and forth between editing .c files and running make. And why to separate the two directories? * Object/binary files are filtered out of versioning system handling by .cvsignore/.gitignore (it does not work with GDB, I guess I should fix it). * Why to have multiple builds out of a single src tree? I do not remember I would ever use that case. And if I had to I just copy the sources. And if I need to save space of the sources files, negligible to the object files size anyway, either * filesystem automatic deduplication does it for me automatically anyway. * or I can just use hardlinks for the source files (cp -al). I probably miss some use case but I never met such use case in the 6 years heavily involved with the toolchain (and neither in its lighter use before). > > From my point of view it does not matter how it > > looks in the out-of-src-tree build. I understand you have to introduce > > separate build directory for gnulib/ in your layout. > > > > Couldn't you just use > > gdb/configure.ac: ACX_CONFIGURE_DIR(["gnulib-src"], ["build-gnulib-gdb"]) > > gdb/gdbserver/configure.ac: ACX_CONFIGURE_DIR(["../gnulib-src"], ["build-gnulib-gdbserver"]) > > and having during in-src-tree build: > > src/gdb/gnulib-src/gnulib/ > > src/gdb/build-gnulib-gdb/gnulib/ > > src/gdb/gdbserver/build-gnulib-gdbserver/gnulib/ > > I could, but look at those duplicate "gnulib/"s anyway... It is all about subjective orientation, I find it easier that at least the parent directory name is unique. This double-directory layout and out-of-src-tree part even during in-src-tree part is sure not ideal. Do you have objections to this layout of slightly less ambigous names? I do not mind renaming it any way, just to keep it unique as I propose above. > I really don't think we should complicate the build to somehow change that. Then there is the toplevel gnulib directory. > I think you'll have cases like these if you build gcc in tree, for example. gcc tree is an exception as: * it has three stages during bootstrap anyway so it just cannot be a single directory. * AFAIK it is usable only after `make install' anyway so one needs the separate installation directory already, so if 2 or 3 directories already does not matter much. Thanks, Jan