From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20478 invoked by alias); 18 Apr 2012 14:52:48 -0000 Received: (qmail 20419 invoked by uid 22791); 18 Apr 2012 14:52:47 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 14:52:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8DAEB1C6D3B; Wed, 18 Apr 2012 10:52:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id keVSHUKAOjGZ; Wed, 18 Apr 2012 10:52:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5A93B1C6CC4; Wed, 18 Apr 2012 10:52:34 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 80BF3145616; Wed, 18 Apr 2012 07:52:25 -0700 (PDT) Date: Wed, 18 Apr 2012 14:54:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [commit 1/3] Import gnulib's update-copyright script Message-ID: <20120418145225.GC2852@adacore.com> References: <1325665146-31682-1-git-send-email-brobecker@adacore.com> <1325665146-31682-2-git-send-email-brobecker@adacore.com> <4F8EB486.5020308@redhat.com> <20120418143606.GA2852@adacore.com> <4F8ED35E.1040208@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F8ED35E.1040208@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00581.txt.bz2 > I don't see how that scripts would have prevented the selective > check-in. :-) Perhaps not, but what I would have done was doing an update first, check that in, and then add the new module. WDYT? > It may help by keeping the git version in some script variable, that > the script checks, instead of having to fetch the version from the > ChangeLog? The new gnulib/ parent directory seems like a good place > for this stuff. Sure. Since there does not appear to be gnulib releases, I was under the impression that we'd always go with the current head, somehow. Having the hash in the script is a good idea, makes things completely reproduceable... -- Joel