From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30785 invoked by alias); 17 Apr 2012 15:42:44 -0000 Received: (qmail 30689 invoked by uid 22791); 17 Apr 2012 15:42:43 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 15:42:10 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q3HFfO6t011856; Tue, 17 Apr 2012 17:41:24 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q3HFfMfI004269; Tue, 17 Apr 2012 17:41:22 +0200 (CEST) Date: Tue, 17 Apr 2012 15:48:00 -0000 Message-Id: <201204171541.q3HFfMfI004269@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: sivachandra@google.com, palves@redhat.com, gdb-patches@sourceware.org, eliz@gnu.org In-reply-to: <20120417145452.GL2852@adacore.com> (message from Joel Brobecker on Tue, 17 Apr 2012 07:54:52 -0700) Subject: Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE References: <20120416144401.GI2852@adacore.com> <4F8C34A8.30101@redhat.com> <20120417145452.GL2852@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00492.txt.bz2 > Date: Tue, 17 Apr 2012 07:54:52 -0700 > From: Joel Brobecker > > > I have modified to put the context diff alternative second. I did not > > remove it altogether as I have not seen more support to removing it. > > > > 2012-04-17 Siva Chandra Reddy > > > > * CONTRIBUTE: Add "cvs diff -up" as a way to generate patches > > when accessing the CVS repository. Add a note saying that the > > "-up" flavors of "cvs diff" and "diff" are preferred. > > I am OK with your version. I think this part is considered > documentation and is more Eli's domain, so please wait for his > approval. > > I also think that 2 GMs agreeing to remove "diff -cp" is enough > to proceed, but I can take care of removing this part once your > patch is in. I don't want you to keep flip-flopping just because > of me. Make that 3. Tristan's recent darwin diffs made me realise that I've completely lost the skill to read diff -c output.