From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3486 invoked by alias); 17 Apr 2012 14:55:15 -0000 Received: (qmail 3471 invoked by uid 22791); 17 Apr 2012 14:55:13 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 14:55:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D59631C679C; Tue, 17 Apr 2012 10:54:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AQFhGyWnqdDN; Tue, 17 Apr 2012 10:54:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 99B5E1C6757; Tue, 17 Apr 2012 10:54:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 39D4E145616; Tue, 17 Apr 2012 07:54:52 -0700 (PDT) Date: Tue, 17 Apr 2012 15:11:00 -0000 From: Joel Brobecker To: Siva Chandra Cc: Pedro Alves , gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE Message-ID: <20120417145452.GL2852@adacore.com> References: <20120416144401.GI2852@adacore.com> <4F8C34A8.30101@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00485.txt.bz2 > I have modified to put the context diff alternative second. I did not > remove it altogether as I have not seen more support to removing it. > > 2012-04-17 Siva Chandra Reddy > > * CONTRIBUTE: Add "cvs diff -up" as a way to generate patches > when accessing the CVS repository. Add a note saying that the > "-up" flavors of "cvs diff" and "diff" are preferred. I am OK with your version. I think this part is considered documentation and is more Eli's domain, so please wait for his approval. I also think that 2 GMs agreeing to remove "diff -cp" is enough to proceed, but I can take care of removing this part once your patch is in. I don't want you to keep flip-flopping just because of me. Cheers, -- Joel > Index: CONTRIBUTE > =================================================================== > RCS file: /cvs/src/src/gdb/CONTRIBUTE,v > retrieving revision 1.12 > diff -u -p -r1.12 CONTRIBUTE > --- CONTRIBUTE 22 Aug 2009 17:08:09 -0000 1.12 > +++ CONTRIBUTE 17 Apr 2012 06:52:34 -0000 > @@ -71,9 +71,11 @@ o Submitting Patches > documentation (i.e., .texi files). > > The patch itself. If you are accessing the CVS repository use > - "cvs update; cvs diff -cp"; else, use "diff -cp OLD NEW" or > - "diff -up OLD NEW". If your version of diff does not support > - these options, then get the latest version of GNU diff. > + "cvs update; cvs diff -up" or "cvs update; cvs diff -cp"; else, > + use "diff -up OLD NEW" or "diff -cp OLD NEW". The flavors with > + "-up" option string are preferred. If your version of diff does > + not support these options, then get the latest version of GNU > + diff. > > We accept patches as plain text (preferred for the compilers > themselves), MIME attachments (preferred for the web pages),