From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29870 invoked by alias); 16 Apr 2012 09:50:12 -0000 Received: (qmail 29840 invoked by uid 22791); 16 Apr 2012 09:50:11 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Apr 2012 09:49:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3G9nsKT026711 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Apr 2012 05:49:54 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3G9noft026363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 16 Apr 2012 05:49:53 -0400 Date: Mon, 16 Apr 2012 10:01:00 -0000 From: Jan Kratochvil To: Hui Zhu Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] breakpoint remove fail handle bug fix Message-ID: <20120416094950.GA10560@host2.jankratochvil.net> References: <4F8549BC.3050003@mentor.com> <20120411203549.GA4715@host2.jankratochvil.net> <4F863B12.2040304@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F863B12.2040304@mentor.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00405.txt.bz2 On Thu, 12 Apr 2012 04:16:50 +0200, Hui Zhu wrote: > But it didn't handle the issue when the target is remote. So a similar fix is needed also for gdbserver, isn't it? One needs to write a testcase for later check-in anyway, testing gdbserver without the testcase/testsuite I find too painful. I still do not see a reason to really handled failed breakpoint removal (or insert), gdbserver also can access /proc/PID/mem etc., cannot it? Thanks, Jan