From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32038 invoked by alias); 13 Apr 2012 21:26:27 -0000 Received: (qmail 32028 invoked by uid 22791); 13 Apr 2012 21:26:26 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_AV,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 21:26:08 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3DLQ4kO027786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 13 Apr 2012 17:26:04 -0400 Received: from host2.jankratochvil.net (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3DLQ03E029489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 13 Apr 2012 17:26:03 -0400 Date: Sat, 14 Apr 2012 03:40:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Link gnulib in gdbserver. Message-ID: <20120413212559.GA5867@host2.jankratochvil.net> References: <1334127046-27627-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1334127046-27627-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00388.txt.bz2 On Wed, 11 Apr 2012 08:50:46 +0200, Yao Qi wrote: > 2012-04-11 Yao Qi > > * Makefile.in: Define abs_top_srcdir and abs_srcdir. > (INCLUDE_CFLAGS): Append GNULIB_INCLUDE_DIR. > (install-only, install-info:, clean:): Handle sub dir gnulib. > (all-lib, am--refresh): New target. > (memmem.o): Remove target. > * configure.ac: Remove AC_CONFIG_LIBOBJ_DIR. > Invoke gl_EARLY. Invoke AC_CHECK_PROGS for make. > (AC_REPLACE_FUNCS): Remove memmem. > Invoke gl_INIT and AM_INIT_AUTOMAKE. > (AC_OUTPUT): Generate Makefile in gnulib/. > * aclocal.m4, config.in, configure: Regenerated. This broken in-src-tree build: make[7]: Entering directory `/home/jkratoch/redhat/gdb-clean/gdb/gdbserver/gnulib' make[7]: Nothing to be done for `all-am'. make[7]: Leaving directory `/home/jkratoch/redhat/gdb-clean/gdb/gdbserver/gnulib' [...] gcc -m64 -ggdb2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -I. -I. -I./../common -I./../regformats -I./../../include -I./../gnulib -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Werror -lmcheck -Wl,--dynamic-list=./proc-service.list -o gdbserver agent.o ax.o inferiors.o regcache.o remote-utils.o server.o signals.o target.o utils.o version.o mem-break.o hostio.o event-loop.o tracepoint.o xml-utils.o common-utils.o ptid.o buffer.o dll.o xml-builtin.o amd64-linux.o amd64-avx-linux.o x32-linux.o x32-avx-linux.o i386-linux.o i386-avx-linux.o i386-mmx-linux.o linux-low.o linux-osdata.o linux-x86-low.o i386-low.o i387-fp.o linux-procfs.o linux-ptrace.o hostio-errno.o thread-db.o proc-service.o \ gnulib/libgnu.a -ldl gcc: error: gnulib/libgnu.a: No such file or directory make[4]: *** [gdbserver] Error 1 make[4]: Leaving directory `/home/jkratoch/redhat/gdb-clean/gdb/gdbserver' I do not like there the VPATH tricks etc., there should be some full copy of gnulib IMO. Regards, Jan