From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21570 invoked by alias); 13 Apr 2012 16:28:39 -0000 Received: (qmail 21550 invoked by uid 22791); 13 Apr 2012 16:28:35 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 16:28:23 +0000 Received: from mudshark.cambridge.arm.com (mudshark.cambridge.arm.com [10.1.79.58]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id q3DGSJOK001131; Fri, 13 Apr 2012 17:28:19 +0100 (BST) Date: Fri, 13 Apr 2012 17:02:00 -0000 From: Will Deacon To: Pedro Alves Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdbserver: ARM: add support for uclinux Message-ID: <20120413162818.GD4605@mudshark.cambridge.arm.com> References: <1334308067-2285-1-git-send-email-will.deacon@arm.com> <4F883EE5.8080407@redhat.com> <20120413155949.GC4605@mudshark.cambridge.arm.com> <4F8852E3.9030003@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F8852E3.9030003@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00370.txt.bz2 On Fri, Apr 13, 2012 at 05:22:59PM +0100, Pedro Alves wrote: > On 04/13/2012 04:59 PM, Will Deacon wrote: > > Although the #defines are exported in the kernel headers, they don't seem to > > be picked up by sys/ptrace.h, which is why I followed the same path as the > > other architectures here. An alternative would be to include asm/ptrace.h > > directly and introduce guards for the other architectures to avoid duplicate > > #defines... > > > I think that'd be good. We already include asm/ptrace.h in many of the linux > native files: > > $ grep asm/ptrace * -rn | grep -v ChangeLog > > amd64-linux-nat.c:39: because the latter redefines FS and GS for no apparent > amd64-linux-nat.c:45:#include > gdbserver/linux-ppc-low.c:25:#include > gdbserver/linux-ia64-low.c:32:#include > gdbserver/linux-mips-low.c:53:#include > gdbserver/linux-tic6x-low.c:37:#include > gdbserver/linux-m68k-low.c:157:#include > gdbserver/linux-bfin-low.c:25:#include > gdbserver/linux-sh-low.c:30:#include > gdbserver/linux-s390-low.c:26:#include > hppa-linux-nat.c:32:#include > ia64-linux-nat.c:39:#include > mips-linux-nat.c:66: These ``addresses'' are normally defined in . > ppc-linux-nat.c:80: ppc kernel's asm/ptrace.h defines PTRACE_GETVRREGS and > s390-nat.c:34:#include > spu-linux-nat.c:33:#include > > So it probably doesn't hurt to include it in linux-low.c. Want to give it a try? Sure, I'll post a v2 next week. I doubt I'll be able to test on coldfire, blackfin and co. though! Cheers, Will