Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: [cancel] [patch] More suggestive error_is_running message
Date: Wed, 11 Apr 2012 15:48:00 -0000	[thread overview]
Message-ID: <20120411153457.GA22022@host2.jankratochvil.net> (raw)
In-Reply-To: <20120411152531.GD2852@adacore.com>

On Wed, 11 Apr 2012 17:25:31 +0200, Joel Brobecker wrote:
> >    error (_("Cannot execute this command while "
> > -	   "the selected thread is running."));
> > +	   "the selected thread is running.  "
> > +	   "(You may want to use 'interrupt' "
> > +	   "and wait for '[Thread N] #1 stopped.'.)"));
> >  }
> 
> Just my two cents on this, I don't really have a strong opinion.
> 
> I'd put the new output on a second line,

OK, I see error is already being used with embedded \n.


> I think that it's OK to drop the part that talks about waiting for the stop
> notification. Once you've used it once, you'll know,

The whole point of my patch was not notify about the _wait_, not about the
_interrupt_, as this is what one cannot easily catch when debugging a testcase
after converting it full-stop -> non-stop.  If you try to reproduce the
problem by hand it works.  OK, I admit I am too stupid to write GDB testcases.


Thanks,
Jan


  reply	other threads:[~2012-04-11 15:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 19:20 Jan Kratochvil
2012-04-10 21:30 ` Sergio Durigan Junior
2012-04-11  2:16   ` Jan Kratochvil
2012-04-11  4:55     ` Sergio Durigan Junior
2012-04-12 15:28       ` Tom Tromey
2012-04-11 15:35 ` Joel Brobecker
2012-04-11 15:48   ` Jan Kratochvil [this message]
2012-04-11 17:17     ` [cancel] " Joel Brobecker
2012-04-17 21:26       ` Jan Kratochvil
2012-04-17 23:01         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120411153457.GA22022@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox