From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8172 invoked by alias); 7 Apr 2012 19:39:32 -0000 Received: (qmail 8164 invoked by uid 22791); 7 Apr 2012 19:39:31 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-bk0-f73.google.com (HELO mail-bk0-f73.google.com) (209.85.214.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 Apr 2012 19:39:17 +0000 Received: by bkcjg15 with SMTP id jg15so151525bkc.0 for ; Sat, 07 Apr 2012 12:39:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=to:subject:message-id:date:from:x-gm-message-state; bh=3qlsYPwjxHxB+UF2ugEOK28KfZENinsiPiVUr/t1g6M=; b=AUcuk0lnvbAb+sS9bUjlP0/jNs65dApLV+iaXtX3uIQKLCX49t0ZaM5CyATpga3aPh 27YQDmXnhGobBJCoMZGTLzD1sjnr8VCzyOCUTx7O8uyJY1r9RK3/NwzPhDxNgac2OdYX B6SDlceSCf5aj2XByO5TJ+kV1l+Bk2qQcGc+w1DPkE/PCmJqrKhh/zwmeh2VTINv3i43 WsmP9/ycf3zvXShUqtUc7RKMMYbPgf1q9ym7RH5yeUeFK7ExdAmS2ZsUdLqj5gkKVeXT QCVq68sArDTcAr267D5E9jbOobYoTAjh5GKnbquyetZFbCN4wz3DsqiPMYYus9ECs7/e BeNw== Received: by 10.14.47.80 with SMTP id s56mr513166eeb.6.1333827556356; Sat, 07 Apr 2012 12:39:16 -0700 (PDT) Received: by 10.14.47.80 with SMTP id s56mr513160eeb.6.1333827556252; Sat, 07 Apr 2012 12:39:16 -0700 (PDT) Received: from hpza9.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id a14si9310169een.0.2012.04.07.12.39.16 (version=TLSv1/SSLv3 cipher=AES128-SHA); Sat, 07 Apr 2012 12:39:16 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.18.110.50]) by hpza9.eem.corp.google.com (Postfix) with ESMTP id 112805C0050 for ; Sat, 7 Apr 2012 12:39:16 -0700 (PDT) Received: by ruffy.mtv.corp.google.com (Postfix, from userid 67641) id 4B21224618E; Sat, 7 Apr 2012 12:39:15 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [commit] dwarf2read.c (load_partial_dies): Change condition to assert. Message-Id: <20120407193915.4B21224618E@ruffy.mtv.corp.google.com> Date: Sat, 07 Apr 2012 19:39:00 -0000 From: dje@google.com (Doug Evans) X-Gm-Message-State: ALoCoQkd/zYIc2ZJ6ub6gBSpthoutyfeigsWElgr6/6Gq0FzBLy/JooxNk/Rbd1tAM1I6/CJU3I18eQlktKEm9WI4wz8r4KkicZuRsBUyl/nbMkNaOf8wF+Z6B4yqzECx3MNxnZn+R1YdS6wZtb7o9v4vaBLPEVo35lMB6fooNMdK0O3gCCxqhM= X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00112.txt.bz2 Hi. There's no caller where cu->per_cu == NULL, and I'd rather have the assert. Regression tested on amd64-linux. 2012-04-07 Doug Evans * dwarf2read.c (load_partial_dies): Change condition to assert. Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.627 diff -u -p -r1.627 dwarf2read.c --- dwarf2read.c 19 Mar 2012 19:59:19 -0000 1.627 +++ dwarf2read.c 7 Apr 2012 19:33:59 -0000 @@ -9522,7 +9522,8 @@ load_partial_dies (bfd *abfd, gdb_byte * parent_die = NULL; last_die = NULL; - if (cu->per_cu && cu->per_cu->load_all_dies) + gdb_assert (cu->per_cu != NULL); + if (cu->per_cu->load_all_dies) load_all = 1; cu->partial_dies