Re: [PATCH] Allow 64-bit enum values

Jan Kratochvil
2012-03-27T17:00:17Z

On Wed, 21 Mar 2012 11:06:32 +0100, Siddhesh Poyarekar wrote:
> I took a separate approach from the one I took in:
>
> http://sourceware.org/ml/gdb-patches/2012-02/msg00403.html
>
> and removed the overloaded meaning of the bitpos location variable to
> fix PR symtab/7259. In the following patch, I introduce a separate
> field_location union member 'enumval' which can accept LONGEST and
> hence expand enum values to 64-bit signed values. With this change,
> bitpos now only is used for (non-negative) offsets into structures,
> since the other overload of bitpos (range bounds) were already
> separated into struct range_bound.

Sorry for respoding so late but what is the point of this enum and offsets
separation? Both need to become 64bit anyway so why to separate them?

Or you find it a better coding style this way?

Thanks,
Jan