Re: [PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST

Jan Kratochvil
2012-06-11T13:00:03Z

On Mon, 11 Jun 2012 14:53:46 +0200, Siddhesh Poyarekar wrote:
> LOC <location>
> - <old>
> - <new>

nitpick: + at the <new> line.

> * Warnings about the argument 2 of extract_unsigned_integer having to
> be int. This is the size of a primitive and is hence always safe.
> * Earlier warning was assignment from int to unsigned int (or
> vice-versa) and that has now changed from LONGEST to ULONGEST.
[...]
> Please let me know if any of the above assumptions or wrong or if there are
> any other cases I can eliminate.

I agree with these assumptions.

Thanks,
Jan