Re: [PATCH v2] Expand bitpos and type.length to LONGEST and ULONGEST

Siddhesh Poyarekar
2012-05-31T06:39:38Z

On Wed, 23 May 2012 19:46:10 +0200, Jan wrote:
> Yes, this size_t change - needs to be also posted to
> binutils@sourceware.org for approval (the bfd/ part). I think it
> should be done first and the mail to binutils@sourceware.org (Cc
> gdb-patches) should not contain parts affecting only gdb/ (it should
> contain parts needed to keep gdb/ compatible with the bfd/ changes).
> Also maybe binutils will have different opinion on it.
>

I was getting the second part of this change ready for submission (the
first part, i.e. the bfd changes are already posted to gdb-patches and
binutils) when I realized that my earlier patch was not consistent with
the size_t changes for read/write to memory. The additional changes
have mainly to do with changes to to_xfer_partial() and related changes
and practically all of it changes LONGEST to size_t. Making these
changes is going to be another large patch (not counting the
bitpos/type.length changes).

Not having the changes will only cause an inconsistency in the code in
terms of readability, but should not affect functionality. Is it OK if I
just post the changes relevant to bitpos/type.length and leave the rest
maybe for later?

Regards,
Siddhesh