From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3872 invoked by alias); 27 Mar 2012 13:56:44 -0000 Received: (qmail 3857 invoked by uid 22791); 27 Mar 2012 13:56:43 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Mar 2012 13:56:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F266E1C6A01; Tue, 27 Mar 2012 09:56:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tPCcN+RbxJzd; Tue, 27 Mar 2012 09:56:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BA2951C69C6; Tue, 27 Mar 2012 09:56:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7C706145616; Tue, 27 Mar 2012 06:56:23 -0700 (PDT) Date: Tue, 27 Mar 2012 13:56:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: "gdb-patches@sourceware.org ml" Subject: Re: [RFA 1/2] Linespec rewrite (update 2) Message-ID: <20120327135623.GC2701@adacore.com> References: <4F70F8F7.503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F70F8F7.503@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00904.txt.bz2 Hi Keith, I tested your patch locally, and unfortunately, it regresses in the following situation: (gdb) break ops.adb:"+":10 FUNCTION:OFFSET is unimplemented It seems to be doing it for all operators, for instance: (gdb) break ops.adb:"/":25 FUNCTION:OFFSET is unimplemented It's a series of tests I meant to add after you check in your patch, because I believe the output changes (that's something we were discussing on Archer). Perhaps it would be better if I wrote a patch to be applied after we apply yours. That way, you can include it in your tree and immediately notice this regression... I'll probably have some time to look at this this afternoon, if you're tied up. Git also notices the following little details when applying your patch: > /home/brobecke/linespec-rewrite-parser-2.patch:810: trailing whitespace. > /* Throw an appropriate error when an unexpected token is encountered > /home/brobecke/linespec-rewrite-parser-2.patch:3180: trailing whitespace. > /home/brobecke/linespec-rewrite-parser-2.patch:3960: trailing whitespace. > { > /home/brobecke/linespec-rewrite-parser-2.patch:4106: trailing whitespace. > add the_tests "$srcfile:main:$x" invalid_label [string trim $x] "main" > /home/brobecke/linespec-rewrite-parser-2.patch:4246: trailing whitespace. > return f.baz (foo::bar () + 3); > warning: squelched 1 whitespace error > warning: 6 lines add whitespace errors. Not terribly important, but easy to fix... -- Joel