From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22134 invoked by alias); 26 Mar 2012 19:05:47 -0000 Received: (qmail 22124 invoked by uid 22791); 26 Mar 2012 19:05:46 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,TW_SM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nick.hrz.tu-chemnitz.de (HELO nick.hrz.tu-chemnitz.de) (134.109.228.11) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Mar 2012 19:05:33 +0000 Received: from 91-65-62-67-dynip.superkabel.de ([91.65.62.67] helo=localhost) by nick.hrz.tu-chemnitz.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1SCFER-0006d0-Cx; Mon, 26 Mar 2012 21:05:31 +0200 Date: Mon, 26 Mar 2012 19:05:00 -0000 From: =?iso-8859-1?Q?Andr=E9_P=F6nitz?= To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Linespec rewrite: Parsing Message-ID: <20120326190530.GA2350@klara.mpi.htwm.de> References: <4F67A319.4090608@redhat.com> <4F6DC651.6060704@gmail.com> <4F6E0319.1080100@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scan-AV: nick.hrz.tu-chemnitz.de;2012-03-26 21:05:31;2db4f079f6180b6fc9197354ea811391 X-Scan-SA: nick.hrz.tu-chemnitz.de;2012-03-26 21:05:31;41a22e1a05375efe2f2781d664696589 X-Spam-Score: -1.0 (-) X-Spam-Report: --- Textanalyse SpamAssassin 3.3.1 (-1.0 Punkte) Fragen an/questions to: Postmaster TU Chemnitz * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP --- Ende Textanalyse X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00882.txt.bz2 On Sun, Mar 25, 2012 at 08:39:41PM -0400, Daniel Jacobowitz wrote: > On Sat, Mar 24, 2012 at 1:23 PM, Keith Seitz > wrote: > > > > On 03/24/2012 06:04 AM, asmwarrior wrote: > > > >> [debug]> break > >> "E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64" > >> [debug]unmatched quote > > > > > > This is now an illegal linespec. You do not need to quote this at > > all. This is one of the motivating factors for doing this rewrite: > > the quoting is _out of control_. [If you do want to quote it, ONLY > > quote the filename portion.] > > > > It appears you may be using the patches I submitted to the list. > > I've committed one or two additional patches for problems I've found > > to the archer branch, one of which deal specifically with quoting > > and embedded colons. > > > > I encourage you to try that branch: > > > > (gdb) break > > E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64 > > > > No source file named > > E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp. > > > > Leaving the quoting in place will force the lookup of the function > > "E:/.../token.cpp:64", which I'm guessing is not what you really > > want. :-) > > This is the change of behavior I think most likely to blow up. > -break-insert proxies straight through to the CLI break command; have > you checked what various other IDEs send today? The most robust "solution" I am aware of is something along the lines of "-break-insert \"\\\"" + c_style_escape(file) + "\\\":" + line + '"' together with a c_style_escape taking care of spaces, quotes etc. This should also be resilient under the proposed changes. Using the more intuitive quote + filename:line + quote has not been sufficient in the past as far as I can tell. Andre'