From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11404 invoked by alias); 25 Mar 2012 07:40:32 -0000 Received: (qmail 11389 invoked by uid 22791); 25 Mar 2012 07:40:31 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 25 Mar 2012 07:40:18 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id D1CA51B4035; Sun, 25 Mar 2012 07:40:17 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: Finalizing fix committed for "[PATCH] sim: make sure to include strsignal prototype" Date: Sun, 25 Mar 2012 07:40:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) Cc: "Hans-Peter Nilsson" References: <1332476592-12930-1-git-send-email-vapier@gentoo.org> <201203241424.16156.vapier@gentoo.org> In-Reply-To: <201203241424.16156.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2680360.ZbMQ6y76SL"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201203250340.21803.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00841.txt.bz2 --nextPart2680360.ZbMQ6y76SL Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1647 On Saturday 24 March 2012 14:24:14 Mike Frysinger wrote: > On Saturday 24 March 2012 06:55:28 Hans-Peter Nilsson wrote: > > I built and and started testing for bfin-elf+unix but got a lot > > of assembly errors for values out-of-range (HEAD binutils, > > perhaps the assembler isn't tested on a 32-bit host?) >=20 > should work, but i'll build it up to see for most tests, it was just old code with too many leading digits (which=20 didn't matter as we only cared about the truncated value which got tested).= i=20 manually tweaked the tests to use 32bit values only. there is one test (fact.s) which is arguably not a bug in the test as the=20 source code specifies the real answer (which is larger than 32bits). as th= e=20 test runs and things start to overflow, this is fine as only the high bits = get=20 truncated away. so we compare the truncated right answer to the truncated= =20 computed answer and are good to go. at any rate, seems to be a bug in common code that only shows up if you are= on=20 a 32bit system and don't specify --enable-64-bit-bfd. simple test case whi= ch=20 hits the same problem regardless of target: $ cat test.s .if 6227020800 & ~0x7fff .endif $ ./as-new test.s=20 test.s: Assembler messages: test.s:1: Warning: left operand is a bignum; integer 0 assumed the BFD64 logic in gas' expr.c is fairly light. i'm not even sure it makes= =20 sense to key off of BFD64 since this code doesn't use bfd for number=20 processing. it's just deciding whether to automatically upgrade bignum's i= nto=20 int64's. i'll post a patch to just delete the BFD64 logic there and see wh= at=20 people have to say. -mike --nextPart2680360.ZbMQ6y76SL Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPbsvlAAoJEEFjO5/oN/WBfWEQAKA0sg21UiTZvg5L4lcnaGCx sKgNMRX/LK+TGc3hUy4SY14nyRJN9EkF5+GlWN0gkLdtobLVohLFSvg4bc5ZqNIs wWCNZDOcxQMGl00OiE50nBdgFuPDAl6hYN8RFutX3syas/jk2mCuHgqM2tAIvV+m R9fwoVbB5B1MfvhQMkKHoyWGDDL3YKIrDexni7Rc9KyVZXt7ZKpG/9sAR2JnfzH3 riyJf2jQlDu8649crF6QPUktWt1V7u7lj2tXIb5MP+tcJcZ9F9FZ837YKWH9GRCU 6MDs9ketf7FoR/sVUaBhmDHbQwuwX63Ahf8Ic1/6TeLv6aSjVLkNYYPh0dudlFr8 gJW+oLNkgaJ45AsjU5YHUQcQ+lRAB/18DkEkxLMjuG9iJrYzg/BabFO+9/H4eNB3 a+8fOZcsJ8wDc8ZGw0bnzClN82WAK3HaWpeapMb3lj4jm1lIBHVW+8hAfKTSvlRb GtPnJiga/7Lx5nPpqUaO44ksyXcE4DVxo0/GJmdSGK+wn4bp7YfPN+rRfWkeABcQ yixcp4KiqBXYiebrVKbc+m+oTU+qhU6XkH3um60NrH+24NGGYUwqHY3QacljsQIk RipwDCh/N1hrv1c6RvjsPemHlHLeaDhqsYzY8NUQiRvwr1M/wlSOanDpvixpw5ZU IAvNjzH6O1oslnTK5SRH =+5WX -----END PGP SIGNATURE----- --nextPart2680360.ZbMQ6y76SL--