From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28582 invoked by alias); 23 Mar 2012 04:23:16 -0000 Received: (qmail 28561 invoked by uid 22791); 23 Mar 2012 04:23:15 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Mar 2012 04:23:01 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id AB7681B400C; Fri, 23 Mar 2012 04:23:00 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: Please fix regressions from your sim changes Date: Fri, 23 Mar 2012 04:23:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) Cc: "Hans-Peter Nilsson" References: <201203201630.q2KGUAp7020158@ignucius.se.axis.com> In-Reply-To: <201203201630.q2KGUAp7020158@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1459002.0TI0E9hlnc"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201203230023.04495.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00798.txt.bz2 --nextPart1459002.0TI0E9hlnc Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1434 On Tuesday 20 March 2012 12:30:10 Hans-Peter Nilsson wrote: > From: Mike Frysinger : > > On Tuesday 20 March 2012 01:54:27 Hans-Peter Nilsson wrote: > > > nrun.o -MMD -MP -MF .deps/nrun.Tpo /tmp/r/sim/cris/../common/nrun.c > > > /tmp/r/sim/cris/../common/nrun.c: In function 'main': > > > /tmp/r/sim/cris/../common/nrun.c:206: warning: implicit declaration of > > > function 'strsignal' /tmp/r/sim/cris/../common/nrun.c:206: warning: > > > format '%s' expects type 'char *', but argument 4 has type 'int' > > > Don't you see that warning? > >=20 > > the code compiles warning free for me > >=20 > > the file should have a string.h include for the strsignal prototype, so > > i'll update that. > >=20=20 > > > Instead, to #define _GNU_SOURCE in the Right Way AFAIK, there > > > should be an AC_GNU_SOURCE (missing) in a configure.* used by > > > all src/sim/* (common/configure.ac AFAICT), and an #include > >=20 > > > "cconfig.h" in nrun.c followed later by the mantra: > > not entirely the right way. my guess is that your older glibc does not > > conform to the newer POSIX spec. strsignal() was added in the 2008 spe= c, > > but old glibc's provided it only when _GNU_SOURCE was defined. >=20 > It's be the right way to maintain interoperability even with old > systems not-fully-conformant-in-every-corner that *used* to > work, that's not what i meant. but it doesn't really matter. patch posted. -mike --nextPart1459002.0TI0E9hlnc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPa/qoAAoJEEFjO5/oN/WBbzwP/318uN2FO3q1a8zTF+cRsYzV T/Nfcxk5PghEkTwgHmEYP3fUC0oBuny0W0ZXcEab9T8MSyK2aUo7JxSuXrygUxzv JtYnwU617HHY52Dqij6Y/SFKTrIWVxi9LAZF4Ks4n2tMt8nD9diT0eMmOLE4CGbQ 850ND3HCLJ+/z9MvpYrNVyV9vTg3/2yGPjgLdvmzaNbCxoiM3y6nBnOd2pQmIEgM wGjp+ENBChkKO53EuZSSe2T24qhBTfORrX4ou0Ou/E2RSpRJ5nnGb2gEr4pBX6JF q1enA/Ve1HkIal+6h/MUYrOg5UEGJHSgflgw5HYH2g5fLat8AME3shlWP9zlTq1N XQuXSkLgPJA5mg8UI3zWLTJEOYqQanLLrympVLv17dtUUwQ/dvwDTRvsHafSRUkG +u229w4woUqIaIEelgzR4BTzCD3YXqnIDaq+o3MpYySYT/jsAtKTwuErtPFp431H 7dQ1pJOJ67Qkw3Yrxv1yHGF/wo5t+oPjbQ/MybAh7NeSNhsz9CAdWBBaMVKxez3z OSZhmxZUN0QNpQ49Xgyw8K3kTfXPsdDOfF1f0Q8azHfbVfKjFujcYBe0/EJSBtg8 3PpNye6tNv1sTL2ZY5qi1nFbMnPrDP9/Y/74JkYImUBnRQzS3WeJXLWjZzy/4xti BSO5JdvNTs2YCFNB3eEP =WSoC -----END PGP SIGNATURE----- --nextPart1459002.0TI0E9hlnc--