Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: merge std-operator.def and ada-operator.def?
Date: Mon, 19 Mar 2012 15:50:00 -0000	[thread overview]
Message-ID: <20120319154941.GX2853@adacore.com> (raw)
In-Reply-To: <20120319153939.GA23668@host2.jankratochvil.net>

> I am not so in favor of it.  Anything than can be made more specific with the
> same user-visible functionality should be made so.  It simplifies maintenance.
> This is the exact reason why I wanted to mark them as OP_ADA_*.
> 
> I understand putting the code into generic parts is easier for you.

I am not doing this because it makes it easier for me; what started
this was the realization that some of the code looks unnecessarily
complex, or not even necessary at all. While I agree with you on
the general principle that language-specific features should be
clearly marked, in this case, I draw from Tom and I's experience with
the type handling and the language vector. Part of the language vector
and the associated complexity would be unnecessary if Ada was more
standard, rather than some side-entity that needs to be plugged into
the core system.

That being said, it's not terribly important to me that some opcodes
are going to be labeled "ADA". It's going to be a bit of a pain for
a while to keep AdaCore's sources in sync, but not difficult. So let's
not discuss this too much and decide what we want to do:

    1. Do we want to go with the propose patch series (merging the def
       files, and then simplifying a bit the code afterwards)?

    2. Do we want to rename the Ada opcodes? I can do that as a third
       patch, for instance.

-- 
Joel


  reply	other threads:[~2012-03-19 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 23:21 Joel Brobecker
2012-03-16 23:21 ` [RFC 1/2] merge std-operator.def & ada-operator.def into one file Joel Brobecker
2012-03-16 23:21 ` [RFC 2/2] Remove op_name callback in struct exp_descriptor Joel Brobecker
2012-03-16 23:29 ` RFC: merge std-operator.def and ada-operator.def? Joel Brobecker
2012-03-19  8:46 ` Jan Kratochvil
2012-03-19 15:34   ` Joel Brobecker
2012-03-19 15:40     ` Jan Kratochvil
2012-03-19 15:50       ` Joel Brobecker [this message]
2012-03-19 15:58         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120319154941.GX2853@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox