From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6677 invoked by alias); 19 Mar 2012 15:07:34 -0000 Received: (qmail 6667 invoked by uid 22791); 19 Mar 2012 15:07:32 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Mar 2012 15:07:08 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 8C34B64C5D; Mon, 19 Mar 2012 15:07:07 +0000 (UTC) From: Mike Frysinger To: "Joseph S. Myers" Subject: Re: [PATCH] sim: use character classes rather than ranges Date: Mon, 19 Mar 2012 15:07:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1332132828-4576-1-git-send-email-vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2239517.TXBCl9Zzyn"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201203191107.07237.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00701.txt.bz2 --nextPart2239517.TXBCl9Zzyn Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1224 On Monday 19 March 2012 07:52:08 Joseph S. Myers wrote: > On Mon, 19 Mar 2012, Mike Frysinger wrote: > > A-Z ranges don't work in all locales, so use character classes instead. >=20 > Are these patterns really meant to depend on the user's locale (and > support locale-specific letters) or are they related to the checked-in > source code (in which case they should support just ASCII letters and > digits - either the relevant program should be run in the C locale, or as > in GCC's option-handling awk scripts the full sets of letters and digits > should be given explicitly somewhere)? >=20 > (Using character classes like you do is fine - *if* either the user's > locale is correct for this code or the programs explicitly run in the C > locale.) some are meant for processing source files which get checked in while other= s=20 are processing user flags. the gennltvals.sh script could be made to work = by=20 forcing a C locale, but the configure script would be tricky. these changes might over match input if the processed source is wrong, but = for=20 all correct inputs, these groups should give the same output regardless of= =20 locale which is why i didn't try going the mess-with-active-locale route. -mike --nextPart2239517.TXBCl9Zzyn Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPZ0ubAAoJEEFjO5/oN/WB9BYP/0T3wNF0/e53l9SNvY8+B+jo 7MPgAuz8Afsecc7mHWltYO2km2lVhFpH9uPFYc7Z1k9sOGWhXiqs63/vSqMP59J8 odKozllChevnyDC1cDGVw+PxQjuD2+FHJzki0I7W8ukP364aw+RQFBu5N4a8edUW 5Dw4V3k34WP7KQWtwx4foN+91utKNUz8+VZhL2DRuW0dD5yJi7e/1OM4LMNbH7XE WPA1ag4P0RKIkIzftgdXdesfFLmGcSgQna83d2qfzgGXQTfCIqmVyQMKjBalx16z o9vH4MA2wWJ1xWfDRR+J0A/jitojE3F81jU5bS9yqjwrceRESt++AEVoawwbeFJe CeuBp6oDw6mOfprLMDGRVaRWgyu4a8CHHINABVfagK0Q+PMTY9Yw00GbTkKePGXv k14cm0TUkgThJv/w/jHbhN9T+CmaF8FwoNXpvNAEb36Q9pqOpnvFh86uaa6qNZMx OSLqU8v9evfmYRVlTohnTHqkDOmZkl92k/1scFRCcZxz46G3m+4cI8mSSo8NH79L 5Ma984VqmbnffM/Aya6jxoXa2L7ODllnXX9ZaAkmTvVZlZDM5bP3nuDz3pdwd5OS l5JVKWERMeyKGHNlWb9py3PRIVKqjT9mZQWili2OhqXfy+HkXSgFmrvcfWSbCXTS iiPdt6HYNaozOCiZf54d =9KXK -----END PGP SIGNATURE----- --nextPart2239517.TXBCl9Zzyn--