From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 457 invoked by alias); 19 Mar 2012 04:17:10 -0000 Received: (qmail 448 invoked by uid 22791); 19 Mar 2012 04:17:09 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Mar 2012 04:16:43 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2J4GTq9008653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Mar 2012 00:16:29 -0400 Received: from spoyarek.redhat.com (vpn1-4-181.ams2.redhat.com [10.36.4.181]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2J4GOwS011218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 19 Mar 2012 00:16:27 -0400 Date: Mon, 19 Mar 2012 04:17:00 -0000 From: Siddhesh Poyarekar To: Jan Kratochvil Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [RFA/Ada] Crash when trying to set value of packed array element Message-ID: <20120319041737.GA24817@spoyarek.redhat.com> References: <1330556589-3594-1-git-send-email-brobecker@adacore.com> <20120316110510.GA25193@host2.jankratochvil.net> <20120316175933.GT2853@adacore.com> <20120316181140.GA7683@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120316181140.GA7683@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00681.txt.bz2 On Fri, Mar 16, 2012 at 07:11:40PM +0100, Jan Kratochvil wrote: > On Fri, 16 Mar 2012 18:59:33 +0100, Joel Brobecker wrote: > > > > - CORE_ADDR new_addr; > > > > + long new_offset = offset; > > > > > > Nitpick - LONGEST (Siddhesh Poyarekar is working on a more thorough fix). > > > > I know you said it's a nitpick, but I don't understand why you think > > it should be LONGEST. "offset" itself is a long, and the only use > > of that new_offset is for set_value_offset, which takes an int. Are > > the changes you are referring to going to make that a LONGEST? > > Yes; not sure if in the first phase but I hope so. Yes, offset has been expanded to LONGEST in the first phase patch. -- Siddhesh