Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix gdb.base/auxv and gdb.base/cond-eval-mode test cases
Date: Sat, 17 Mar 2012 07:27:00 -0000	[thread overview]
Message-ID: <20120317072843.GA25580@spoyarek.redhat.com> (raw)
In-Reply-To: <4F63613A.4080501@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

On Fri, Mar 16, 2012 at 03:50:18PM +0000, Pedro Alves wrote:
> > 	* gdb.base/cond-eval-mode.exp: Fix the anticipated warning
> > 	string
> 
> 
> Please always send separate logical changes as separate emails, each with
> its own subject line, description and patch.  This part is obvious and
> could have gone in immediately.
> 

I have attached the cond-eval-mode.exp change here. I'll send another
email for the ulimit change.

--
Siddhesh


testsuite/ChangeLog:

2012-03-16  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* gdb.base/cond-eval-mode.exp: Fix the anticipated warning
	string

[-- Attachment #2: fix-test-cases.patch --]
[-- Type: text/plain, Size: 711 bytes --]

diff --git a/gdb/testsuite/gdb.base/cond-eval-mode.exp b/gdb/testsuite/gdb.base/cond-eval-mode.exp
index dbbfc28..965c497 100644
--- a/gdb/testsuite/gdb.base/cond-eval-mode.exp
+++ b/gdb/testsuite/gdb.base/cond-eval-mode.exp
@@ -30,7 +30,7 @@ gdb_test_no_output $test_auto
 
 # If target-side condition evaluation is not supported, this warning will be
 # displayed.
-set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing GDB evaluation mode instead.\r\n"
+set warning "warning: Target does not support breakpoint condition evaluation.\r\nUsing host evaluation mode instead.\r\n"
 
 gdb_test_multiple $test_target $test_target {
     -re "$warning$gdb_prompt $" {
-- 
1.7.7.4


  reply	other threads:[~2012-03-17  7:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 14:29 Siddhesh Poyarekar
2012-03-16 15:50 ` Pedro Alves
2012-03-17  7:27   ` Siddhesh Poyarekar [this message]
2012-03-19  9:35     ` [commit] " Jan Kratochvil
2012-03-17  7:37   ` [PATCH] Fix core dump test case failure with a ulimit check in gdb.base/auxv.exp Siddhesh Poyarekar
2012-03-19  9:43     ` Jan Kratochvil
2012-03-19 15:57       ` Siddhesh Poyarekar
2012-03-19 16:13         ` Jan Kratochvil
2012-03-19 16:39           ` Siddhesh Poyarekar
2012-03-19 18:40             ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120317072843.GA25580@spoyarek.redhat.com \
    --to=siddhesh@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox