From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Siddhesh Poyarekar <siddhesh@redhat.com>
Subject: Re: [RFA/Ada] Crash when trying to set value of packed array element
Date: Fri, 16 Mar 2012 18:50:00 -0000 [thread overview]
Message-ID: <20120316181140.GA7683@host2.jankratochvil.net> (raw)
In-Reply-To: <20120316175933.GT2853@adacore.com>
On Fri, 16 Mar 2012 18:59:33 +0100, Joel Brobecker wrote:
> > > - CORE_ADDR new_addr;
> > > + long new_offset = offset;
> >
> > Nitpick - LONGEST (Siddhesh Poyarekar is working on a more thorough fix).
>
> I know you said it's a nitpick, but I don't understand why you think
> it should be LONGEST. "offset" itself is a long, and the only use
> of that new_offset is for set_value_offset, which takes an int. Are
> the changes you are referring to going to make that a LONGEST?
Yes; not sure if in the first phase but I hope so.
> I'll fix that as a followup patch if you confirm the above.
I do not think it matters if it is checked in as is, there is a huge amount of
such cases needing to be caught anyway.
Thanks,
Jan
next prev parent reply other threads:[~2012-03-16 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 23:15 Joel Brobecker
2012-03-14 20:54 ` Ping: " Joel Brobecker
2012-03-16 11:06 ` Jan Kratochvil
2012-03-16 18:00 ` Joel Brobecker
2012-03-16 18:50 ` Jan Kratochvil [this message]
2012-03-19 4:17 ` Siddhesh Poyarekar
2012-03-19 15:54 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316181140.GA7683@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox