From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26609 invoked by alias); 14 Mar 2012 09:02:53 -0000 Received: (qmail 26573 invoked by uid 22791); 14 Mar 2012 09:02:52 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Mar 2012 09:02:34 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2E92Y9r007280 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 14 Mar 2012 05:02:34 -0400 Received: from host2.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2E92T5F028683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 14 Mar 2012 05:02:32 -0400 Date: Wed, 14 Mar 2012 09:02:00 -0000 From: Jan Kratochvil To: Kevin Buettner Cc: gdb-patches@sourceware.org, Keith Seitz , Pedro Alves Subject: Re: [RFC] symtab.c: Change skip_prologue_sal comparison to match main() too Message-ID: <20120314090228.GA13802@host2.jankratochvil.net> References: <20120313155817.44b4f280@mesquite.lan> <4F5FD74B.1090500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F5FD74B.1090500@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00473.txt.bz2 On Wed, 14 Mar 2012 00:24:59 +0100, Pedro Alves wrote: > I'm going to guess this is fallback from physname. The code looked like > this when it was originally added: > > + /* On targets with executable formats that don't have a concept of > + constructors (ELF with .init has, PE doesn't), gcc emits a call > + to `__main' in `main' between the prologue and before user > + code. */ > + if (funfirstline > + && gdbarch_skip_main_prologue_p (current_gdbarch) > + && SYMBOL_LINKAGE_NAME (sym) > + && strcmp (SYMBOL_LINKAGE_NAME (sym), "main") == 0) > > And SYMBOL_LINKAGE_NAME (sym) used to be "main" for C++ too. This is: regression by physname: PE32 prologue skip vs. static initializers http://sourceware.org/bugzilla/show_bug.cgi?id=12680 I would welcome also a testcase, though. Thanks, Jan