Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 2/3] attach-fail-reasons: Say more than ptrace: Operation not permitted.
Date: Tue, 13 Mar 2012 14:50:00 -0000	[thread overview]
Message-ID: <20120313145034.GA354@host2.jankratochvil.net> (raw)
In-Reply-To: <4F5F5B0F.8010804@redhat.com>

On Tue, 13 Mar 2012 15:34:55 +0100, Pedro Alves wrote:
> E.g., with a multi-threaded exec, the execing thread just disappears
> from /proc/TID as in reality the kernel changed the execing thread's TID, so
> it's possible we end trying to open the non-existing /proc/TID/... before handling
> the exec event.  I think there were other ways for a tracee to be completely
> killed/removed behind the tracer's back, but maybe that was only with older kernels,
> if it ever was.

I do not see when exactly this race may happen.

Still I always thought /proc is racy by design, it does not have to be (not
sure if it currently is or is not).


> dynamic string growth with delete[]/new[] to reallocate (instead of std::string, not
> knowing its existence),

The difference is statistically everyone knows STL but nobody knows
GDB-specific (or Sourceware-specific) libraries/functions.  This makes
learning curve of possible contributors needlessly steep.


Thanks,
Jan


  reply	other threads:[~2012-03-13 14:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06  6:17 Jan Kratochvil
2012-03-08 13:55 ` Pedro Alves
2012-03-13  9:43   ` Jan Kratochvil
2012-03-13 10:33     ` Pedro Alves
2012-03-13 13:55       ` Jan Kratochvil
2012-03-13 14:35         ` Pedro Alves
2012-03-13 14:50           ` Jan Kratochvil [this message]
2012-03-13 15:03           ` [commit] " Jan Kratochvil
2012-03-14 15:12         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313145034.GA354@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox