From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30613 invoked by alias); 12 Mar 2012 15:30:39 -0000 Received: (qmail 30601 invoked by uid 22791); 12 Mar 2012 15:30:37 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Mar 2012 15:30:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AA3EF1C67AF; Mon, 12 Mar 2012 11:30:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ueO0S1czyLCp; Mon, 12 Mar 2012 11:30:22 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2497C1C6621; Mon, 12 Mar 2012 11:30:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C1FB6145615; Mon, 12 Mar 2012 08:30:16 -0700 (PDT) Date: Mon, 12 Mar 2012 15:30:00 -0000 From: Joel Brobecker To: Chris January Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Support Fortran common blocks with addresses >INT_MAX. Message-ID: <20120312153016.GJ2853@adacore.com> References: <1331217037.2742.10.camel@gumtree> <20120309193904.GF2853@adacore.com> <1331541910.2783.2.camel@gumtree> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331541910.2783.2.camel@gumtree> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00403.txt.bz2 > > > 2012-03-08 Chris January > > > > > > * stabsread.c (fix_common_block): Change type of valu argument > > > to CORE_ADDR. > > > > This change looks correct to me too. Did you run the testsuite to > > validate the change, by any chance? > > No, although there aren't any test cases in testsuite/gdb.fortran that > use a common block anyway. The problem is that this potentially affects more than just Fortran programs using common blocks. Would you have a GNU/Linux box available? You could test your change a little differently, by running the testsuite with -gstabs+. I think the following command should work: % make check RUNTESTFLAGS="--target_board % unix/gdb:debug_flags=-gstabs+" The second issue that this raises is that it would be nice to have one such testcase to detect future changes that might break this. But given that this is stabs, and that stabs are on their last breath, I am not going to insist on it this time around, especially if it is going to take lots of time from you. FYI: We, at AdaCore, switch to DWARF on AIX last year. We had to move to GNU ld for that. One thing I have to say, we're not sorry to be rid of stabs. > > Do you have copyright assignment papers on file with the FSF? If not, > > this change is sufficiently small that we can accept it, as well as > > your other contribution ("Add another way of setting up [...]"). > > Yes, we have a company-wide assignment. OK, found it! Thanks... -- Joel