From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7105 invoked by alias); 9 Mar 2012 19:48:57 -0000 Received: (qmail 7081 invoked by uid 22791); 9 Mar 2012 19:48:56 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 19:48:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3502C1C6A31; Fri, 9 Mar 2012 14:48:43 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id U8ncic4TaVGh; Fri, 9 Mar 2012 14:48:43 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E8D9B1C6A14; Fri, 9 Mar 2012 14:48:42 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 102CE145615; Fri, 9 Mar 2012 11:48:34 -0800 (PST) Date: Fri, 09 Mar 2012 19:48:00 -0000 From: Joel Brobecker To: Chris January Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] AIX: Add another way of setting up the frame pointer to skip_prologue Message-ID: <20120309194834.GG2853@adacore.com> References: <1331217602.2742.14.camel@gumtree> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331217602.2742.14.camel@gumtree> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00348.txt.bz2 Chris, > Add support for compilers that use the oril r29, r1, 0x0 instruction to > set up the frame pointer. > > 2012-03-08 Chris January > > * rs6000-tdep.c (skip_prologue): Support the oril r29, r1, 0x0 > instruction. Same comments as before: Looks good, but has it been validated against the testsuite? I am just going to suggest one tiny change, which is a bit of a nitpick, but I think makes the code relatively consistent: > --- > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index a8ff777..9d4fd40 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -1822,6 +1822,15 @@ skip_prologue (struct gdbarch *gdbarch, CORE_ADDR > pc, CORE_ADDR lim_pc, > > /* Set up frame pointer */ > } > + else if (op == 0x603d0000 /* oril r29, r1, 0x0 */) I would put the comment outside of the closing parens. I know we do this for multi-line conditions, but this one fits in a single line, so we can put it outside, and that way, it doesn't look like a parens is missing. > + { > + fdata->frameless = 0; > + framep = 1; > + fdata->alloca_reg = (tdep->ppc_gp0_regnum + 29); > + continue; > + > + /* Another way to set up the frame pointer. */ > + } > else if (op == 0x603f0000 /* oril r31, r1, 0x0 */ > || op == 0x7c3f0b78) > { /* mr r31, r1 */ > -- Joel