From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8453 invoked by alias); 9 Mar 2012 13:40:47 -0000 Received: (qmail 8322 invoked by uid 22791); 9 Mar 2012 13:40:44 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 13:40:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 44CC01C6AA3; Fri, 9 Mar 2012 08:40:23 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 56jMGfl+orLN; Fri, 9 Mar 2012 08:40:23 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EE7251C68F7; Fri, 9 Mar 2012 08:40:22 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BA74E145615; Fri, 9 Mar 2012 05:40:14 -0800 (PST) Date: Fri, 09 Mar 2012 13:40:00 -0000 From: Joel Brobecker To: Josh Matthews Cc: gdb-patches@sourceware.org, Tristan Gingold Subject: Re: [patch] Darwin build fix for unused prototypes Message-ID: <20120309134014.GB2853@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00331.txt.bz2 Hi Josh, > 2012-03-08 Josh Matthews > > * darwin-nat-info.c: Add missing prototype for > _initialize_darwin_info_commands. Make darwin_debug_port_info static. > * darwin-nat.c: Add missing prototype for _initialize_darwin_infereior. > * i386-darwin-nat.c: Remove unused functions > i386_darwin_dr_set, i386_darwin_dr_get, i386_darwin_set_control, > i386_darwin_get_control, i386_darwin_dr_set_addr, > i386_darwin_get_addr, i386_darwin_get_status, i386_darwin_get_control. > * machoread.c: Add missing prototype for _initialize_machoread. Before you commit, can you make sure you re-format this ChangeLog entry so that all the text is aligned on a tab? Also, can you use two spaces after each period. And finally, I noticed at least one typo: _initialize_darwin_infereior I suggest: * darwin-nat-info.c (_initialize_darwin_info_commands): Add prototype. (darwin_debug_port_info): Make static. * darwin-nat.c (_initialize_darwin_inferior): Add prototype. * machoread.c (_initialize_machoread): Add prototype. * i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr_get) (i386_darwin_set_control, i386_darwin_get_control) i386_darwin_dr_set_addr, i386_darwin_get_addr) i386_darwin_get_status, i386_darwin_get_control): Comment these functions out. -- Joel