From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11140 invoked by alias); 6 Mar 2012 23:46:07 -0000 Received: (qmail 11130 invoked by uid 22791); 6 Mar 2012 23:46:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Mar 2012 23:45:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D87121C64DE; Tue, 6 Mar 2012 18:45:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OjWyBODjdc6n; Tue, 6 Mar 2012 18:45:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A24DB1C64DD; Tue, 6 Mar 2012 18:45:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A2269145615; Tue, 6 Mar 2012 15:45:40 -0800 (PST) Date: Tue, 06 Mar 2012 23:46:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: problem with DW_OP_GNU_deref_type and dwarf's get_base_type callback Message-ID: <20120306234540.GN2853@adacore.com> References: <20120305223429.GM2867@adacore.com> <87boo9tr2u.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87boo9tr2u.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00211.txt.bz2 > >>>>> "Joel" == Joel Brobecker writes: > > Joel> * dwarf2read.c (dwarf2_get_die_type): Pass absolute offset > Joel> in call to get_die_type_at_offset. > > I agree with your analysis and this patch. Thanks for the review, Tom. I just checked the patch in. I'm sure Jan will let me know if it causes any regression :-). -- Joel