Re: i387-tdep.c:i387_supply_xsave: Assert the xsave section buffer, is not NULL.

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Mon, 05 Mar 2012 14:32:32 +0000
> From: Pedro Alves <palves@redhat.com>
> 
> On 01/26/2012 07:07 PM, Pedro Alves wrote:
> 
> > 
> > I have a doubt in the xsave-in-corefile support bits.  There's
> > code in place to handle a NULL regs (as in no xsave contents to
> > work with), so I'm handling it as presently:
> > 
> > +
> > +     Note however, the case when REGS is NULL is a different case.
> > +     That case means we do not have access to the x87 states, so we
> > +     should mark the registers as unavailable (by supplying NULL).  */
> > +
> > 
> > but I can't figure out how would we ever get a NULL REGS there.  Is there a
> > convoluted path I missed?  amd64-linux-tdep.c unconditionally installs
> > amd64_linux_regset_sections as gdbarch_core_regset_sections
> > callback, and this includes the .reg-xstate section.
> > However, corelow.c:get_core_register_section bails early if
> > a section is not found in the core, never reaching regset->supply_regset
> > with a NULL `contents'.
> 
> 
> On 02/27/2012 06:48 PM, Pedro Alves wrote:
> > I'll post a separate RFC patch proposing to remove the NULL REGS handling
> 
> Here's what I'd like to check in, given the analysis quoted above.

I agree with your analysis.