From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22198 invoked by alias); 3 Mar 2012 14:02:53 -0000 Received: (qmail 22171 invoked by uid 22791); 3 Mar 2012 14:02:50 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Mar 2012 14:02:32 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q23E2JpZ015168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Mar 2012 09:02:19 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q23E2D0H023617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 3 Mar 2012 09:02:16 -0500 Date: Sat, 03 Mar 2012 14:02:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] print packed arrays indexed by enumerated type Message-ID: <20120303140213.GA21463@host2.jankratochvil.net> References: <1330544108-25710-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330544108-25710-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00110.txt.bz2 On Wed, 29 Feb 2012 20:35:08 +0100, Joel Brobecker wrote: > gdb/ChangeLog: > > * ada-lang.c (constrained_packed_array_type): If there is a > parallel XA type, use it to determine the array index type. > > gdb/testsuite/ChangeLog: > > * gdb.ada/arrayidx.exp: Adjust expected output for p_one_two_three. > * gdb.ada/enum_idx_packed: New testcase. Do you agree with these XFAILs? I did not bisect which GCC change it was. Also gcc-4.7.0-0.16.fc17.x86_64 still FAILs despite it is 4.7; but that may change with later updates, not sure. Regards, Jan gdb/testsuite/ 2012-03-03 Jan Kratochvil * gdb.ada/arrayidx.exp: Call get_compiler_info. New variable old_gcc. (print one_two_three, indexes off, print few_reps, indexes off) (print many_reps, indexes off, print empty, indexes off) (print one_two_three, print few_reps, print many_reps, print empty): Call setup_xfail if $gcc_old. --- a/gdb/testsuite/gdb.ada/arrayidx.exp +++ b/gdb/testsuite/gdb.ada/arrayidx.exp @@ -27,6 +27,12 @@ if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} { return -1 } +if [get_compiler_info ${binfile}] { + return -1; +} +set old_gcc [expr [test_compiler_info {gcc-[0-3]-*}] \ + || [test_compiler_info {gcc-4-[0-6]-*}]] + clean_restart ${testfile} set bp_location [gdb_get_line_number "START" ${testdir}/p.adb] @@ -36,6 +42,9 @@ runto "p.adb:$bp_location" gdb_test_no_output "set print array-indexes off" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print one_two_three" \ "= \\(1, 2, 3\\)" \ "print one_two_three, indexes off" @@ -56,14 +65,23 @@ gdb_test "print p_one_two_three" \ "= \\(false, true, true\\)" \ "print p_one_two_three, indexes off" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print few_reps" \ "= \\(1, 2, 3, 3, 3, 3, 3, 4, 5\\)" \ "print few_reps, indexes off" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print many_reps" \ "= \\(1, 2, 3 , 4, 5\\)" \ "print many_reps, indexes off" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print empty" \ "= \\(\\)" \ "print empty, indexes off" @@ -72,6 +90,9 @@ gdb_test "print empty" \ gdb_test_no_output "set print array-indexes on" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print one_two_three" \ "= \\(1 => 1, 2 => 2, 3 => 3\\)" \ "print one_two_three" @@ -92,14 +113,23 @@ gdb_test "print p_one_two_three" \ "= \\(one => false, two => true, three => true\\)" \ "print p_one_two_three" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print few_reps" \ "= \\(1 => 1, 2 => 2, 3 => 3, 4 => 3, 5 => 3, 6 => 3, 7 => 3, 8 => 4, 9 => 5\\)" \ "print few_reps" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print many_reps" \ "= \\(1 => 1, 2 => 2, 3 => 3 , 15 => 4, 16 => 5\\)" \ "print many_reps" +if $old_gcc { + setup_xfail "*-*-*" +} gdb_test "print empty" \ "= \\(\\)" \ "print empty"