From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15258 invoked by alias); 2 Mar 2012 13:46:11 -0000 Received: (qmail 15037 invoked by uid 22791); 2 Mar 2012 13:46:08 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Mar 2012 13:45:51 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q22DjmB2011632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 2 Mar 2012 08:45:48 -0500 Received: from mesquite.lan (ovpn-113-100.phx2.redhat.com [10.3.113.100]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q22Djl1E004687 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 2 Mar 2012 08:45:48 -0500 Date: Fri, 02 Mar 2012 13:46:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [RFC] sh-tdep.c: Don't fetch FPSCR register if it doesn't exist Message-ID: <20120302064547.2c15add4@mesquite.lan> In-Reply-To: <87pqcv2w64.fsf@schwinge.name> References: <20120229173408.78699013@mesquite.lan> <20120301013318.GJ3118@adacore.com> <20120229220932.17ad0d5f@mesquite.lan> <877gz44nre.fsf@schwinge.name> <20120301111926.14b1025b@mesquite.lan> <87pqcv2w64.fsf@schwinge.name> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00085.txt.bz2 On Fri, 02 Mar 2012 10:23:47 +0100 Thomas Schwinge wrote: > > * sh-tdep.c (sh_frame_cache): Don't fetch the FPSCR register > > unless it exists for this architecture. > > Looks good; before committing, you may want to unify spaces/tabs usage > used for indenting the comment. Thanks for noticing that. I've fixed it in my tree. (Don't think it's worth posting a new patch for it.) Kevin