Re: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c

Maciej W. Rozycki
2012-03-09T08:16:16Z

On Fri, 9 Mar 2012, Joel Brobecker wrote:

> > > - perror_with_name ("ptrace");
> > > + perror_with_name (_("ptrace"));
> > > break;
> > > }
> > > }
> >
> > Hmm, I'm not sure if "ptrace" can be translated to anything as it's a
> > proper name; however if you're in a picky mood, then watch out for
> > numerous cases like this:
>
> Yeah, these are a little silly. One way to make the a little less
> silly, perhaps, would be to have a better message... But not worth
> spending time over, if you ask me.

Yes, I can't comment on the others, but this "ptrace" one surely is for
an "impossible" error condition (system on fire, anyone?), so it doesn't
really make sense to put a lot of effort into it as perror will already
have provided some kind of a comprehensive explanation.

What about the other issue I noted however, i.e.:

gdb/event-loop.c: perror_with_name (("poll"));

vs expected:

gdb/event-loop.c: perror_with_name (_("poll"));

(and so on) -- these clearly look like an oversight.

Maciej