Re: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c

Pedro Alves
2012-03-09T11:22:13Z

On 03/09/2012 08:15 AM, Maciej W. Rozycki wrote:

> What about the other issue I noted however, i.e.:
>
> gdb/event-loop.c: perror_with_name (("poll"));
>
> vs expected:
>
> gdb/event-loop.c: perror_with_name (_("poll"));
>
> (and so on) -- these clearly look like an oversight.

I don't think so. I think this is the way to silence the ARI for strings
that should not be translated. See:

$ grep "((\"" *
ada-lang.c: printf_unfiltered (("[%d] "), i + first_choice);
ada-lang.c: error (("%s"), err_msg);
annotate.c: printf_filtered (("*"));
annotate.c: printf_filtered (("-"));
annotate.c: printf_unfiltered (("\n\032\032breakpoints-invalid\n"));
annotate.c: printf_filtered (("\n\032\032breakpoint %d\n"), num);
annotate.c: printf_filtered (("\n\032\032catchpoint %d\n"), num);
annotate.c: printf_filtered (("\n\032\032watchpoint %d\n"), num);
annotate.c: printf_filtered (("\n\032\032starting\n"));
annotate.c: printf_filtered (("\n\032\032stopped\n"));
annotate.c: printf_filtered (("\n\032\032exited %d\n"), exitstatus);
annotate.c: printf_filtered (("\n\032\032signalled\n"));
annotate.c: printf_filtered (("\n\032\032signal-name\n"));
annotate.c: printf_filtered (("\n\032\032signal-name-end\n"));
annotate.c: printf_filtered (("\n\032\032signal-string\n"));
annotate.c: printf_filtered (("\n\032\032signal-string-end\n"));
annotate.c: printf_filtered (("\n\032\032signal\n"));
annotate.c: printf_filtered (("\n\032\032breakpoints-headers\n"));
annotate.c: printf_filtered (("\n\032\032field %d\n"), num);
annotate.c: printf_filtered (("\n\032\032breakpoints-table\n"));
annotate.c: printf_filtered (("\n\032\032record\n"));
annotate.c: printf_filtered (("\n\032\032breakpoints-table-end\n"));
annotate.c: printf_unfiltered (("\n\032\032frames-invalid\n"));
annotate.c: printf_unfiltered (("\n\032\032new-thread\n"));
annotate.c: printf_unfiltered (("\n\032\032thread-changed\n"));
annotate.c: printf_filtered (("\n\032\032field-begin "));
annotate.c: printf_filtered (("\n"));
annotate.c: printf_filtered (("\n\032\032field-name-end\n"));
annotate.c: printf_filtered (("\n\032\032field-value\n"));
annotate.c: printf_filtered (("\n\032\032field-end\n"));
annotate.c: printf_filtered (("\n\032\032quit\n"));
annotate.c: printf_filtered (("\n\032\032error\n"));
annotate.c: printf_filtered (("\n\032\032value-history-begin %d "), histindex);
annotate.c: printf_filtered (("\n"));
annotate.c: printf_filtered (("\n\032\032value-begin "));
annotate.c: printf_filtered (("\n"));
annotate.c: printf_filtered (("\n\032\032value-history-value\n"));
annotate.c: printf_filtered (("\n\032\032value-history-end\n"));
annotate.c: printf_filtered (("\n\032\032value-end\n"));
annotate.c: printf_filtered (("\n\032\032display-begin\n"));
annotate.c: printf_filtered (("\n\032\032display-number-end\n"));
annotate.c: printf_filtered (("\n\032\032display-format\n"));
annotate.c: printf_filtered (("\n\032\032display-expression\n"));
annotate.c: printf_filtered (("\n\032\032display-expression-end\n"));
annotate.c: printf_filtered (("\n\032\032display-value\n"));
annotate.c: printf_filtered (("\n\032\032display-end\n"));
annotate.c: printf_filtered (("\n\032\032arg-begin\n"));
annotate.c: printf_filtered (("\n\032\032arg-name-end\n"));
annotate.c: printf_filtered (("\n\032\032arg-value "));
annotate.c: printf_filtered (("\n"));
annotate.c: printf_filtered (("\n\032\032arg-end\n"));
annotate.c: printf_filtered (("\n\032\032source "));
annotate.c: printf_filtered (("\032\032"));
annotate.c: printf_filtered (("%s:%d:%d:%s:%s\n"), filename, line, character,
annotate.c: printf_filtered (("\n\032\032frame-begin %d %s\n"),
annotate.c: printf_filtered (("\n\032\032function-call\n"));
annotate.c: printf_filtered (("\n\032\032signal-handler-caller\n"));
annotate.c: printf_filtered (("\n\032\032frame-address\n"));
annotate.c: printf_filtered (("\n\032\032frame-address-end\n"));
annotate.c: printf_filtered (("\n\032\032frame-function-name\n"));
annotate.c: printf_filtered (("\n\032\032frame-args\n"));
annotate.c: printf_filtered (("\n\032\032frame-source-begin\n"));
annotate.c: printf_filtered (("\n\032\032frame-source-file\n"));
annotate.c: printf_filtered (("\n\032\032frame-source-file-end\n"));
annotate.c: printf_filtered (("\n\032\032frame-source-line\n"));
annotate.c: printf_filtered (("\n\032\032frame-source-end\n"));
annotate.c: printf_filtered (("\n\032\032frame-where\n"));
annotate.c: printf_filtered (("\n\032\032frame-end\n"));
annotate.c: printf_filtered (("\n\032\032array-section-begin %d "), idx);
annotate.c: printf_filtered (("\n"));
annotate.c: printf_filtered (("\n\032\032elt-rep %u\n"), repcount);
annotate.c: printf_filtered (("\n\032\032elt-rep-end\n"));
annotate.c: printf_filtered (("\n\032\032elt\n"));
annotate.c: printf_filtered (("\n\032\032array-section-end\n"));
bsd-kvm.c: error (("%s"), errbuf);
bsd-kvm.c: warning (("%s"), kvm_geterr(core_kd));
bsd-kvm.c: error (("%s"), kvm_geterr (core_kd));
bsd-kvm.c: error (("%s"), kvm_geterr (core_kd));
bsd-kvm.c: error (("%s"), kvm_geterr (core_kd));
bsd-kvm.c: error (("%s"), kvm_geterr (core_kd));
bsd-kvm.c: error (("%s"), kvm_geterr (core_kd));
bsd-kvm.c: error (("%s"), kvm_geterr (core_kd));
bsd-kvm.c: error (("%s"), kvm_geterr (core_kd));
event-loop.c: perror_with_name (("poll"));
event-loop.c: perror_with_name (("select"));
event-top.c: printf_unfiltered (("\n\032\032post-"));
event-top.c: printf_unfiltered (("\n"));
fork-child.c: perror_with_name (("vfork"));
frame.c: error (("%s"), message);
gdbtypes.c: printf_filtered (("1"));
gdbtypes.c: printf_filtered (("0"));
gnu-nat.c: error (("%s."), safe_strerror (err));
i386fbsd-nat.c: perror_with_name (("ptrace"));
i386-linux-nat.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ptrace.c: perror_with_name (("waitpid"));
inf-ptrace.c: perror_with_name (("ptrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace_wait"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("pipe"));
inf-ttrace.c: perror_with_name (("pipe"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("write"));
inf-ttrace.c: perror_with_name (("read"));
inf-ttrace.c: perror_with_name (("read"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("write"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace_wait"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace"));
inf-ttrace.c: perror_with_name (("ttrace_wait"));
inf-ttrace.c: perror_with_name (("ttrace"));
linux-nat.c: perror_with_name (("fork"));
linux-nat.c: perror_with_name (("waitpid"));
linux-thread-db.c: (("%s")), thread_db_err_str (err));
source.c: error (("%s"), msg);
source.c: error (("%s"), msg);
utils.c: error (("%s"), message);
utils.c: printf_filtered (("\n\032\032pre-query\n"));
utils.c: printf_filtered (("\n\032\032query\n"));
utils.c: printf_filtered (("\n\032\032post-query\n"));
utils.c: printf_unfiltered (("\n\032\032pre-prompt-for-continue\n"));
utils.c: printf_unfiltered (("\n\032\032post-prompt-for-continue\n"));
value.c: printf_filtered (("$%d = "), i);
value.c: printf_filtered (("\n"));
value.c: printf_filtered (("$%s = "), var->name);
value.c: printf_filtered (("\n"));
windows-nat.c: warning (("%s"), s);

--
Pedro Alves