From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10705 invoked by alias); 1 Mar 2012 15:57:08 -0000 Received: (qmail 10695 invoked by uid 22791); 1 Mar 2012 15:57:07 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Mar 2012 15:56:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 608181C6C93; Thu, 1 Mar 2012 10:56:52 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6iOK2tENXavK; Thu, 1 Mar 2012 10:56:52 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 23E961C686D; Thu, 1 Mar 2012 10:56:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id F3868145615; Thu, 1 Mar 2012 07:56:45 -0800 (PST) Date: Thu, 01 Mar 2012 15:57:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [RFC] sh-tdep.c: Don't fetch FPSCR register if it doesn't exist Message-ID: <20120301155645.GA2853@adacore.com> References: <20120229173408.78699013@mesquite.lan> <20120301013318.GJ3118@adacore.com> <20120229220932.17ad0d5f@mesquite.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120229220932.17ad0d5f@mesquite.lan> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00023.txt.bz2 > What do you think? > > Here's an updated patch: > > * sh-tdep.c (sh_frame_cache): Don't fetch the FPSCR register > unless it exists for this architecture. FWIW, I don't know if it is *the* canonical approach (or if there is any), but it seems like a very reasonable one. -- Joel