From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10860 invoked by alias); 29 Feb 2012 20:16:41 -0000 Received: (qmail 10843 invoked by uid 22791); 29 Feb 2012 20:16:35 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 20:16:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F14C61C6760; Wed, 29 Feb 2012 15:16:21 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id C0rWDnBe5-kb; Wed, 29 Feb 2012 15:16:21 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B60791C675D; Wed, 29 Feb 2012 15:16:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0ADA3145615; Wed, 29 Feb 2012 12:16:15 -0800 (PST) Date: Wed, 29 Feb 2012 22:41:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 14/14] -Wmissing-prototypes: Build with -Wmissing-prototypes by default. Message-ID: <20120229201615.GI3118@adacore.com> References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> <20120229162127.23918.7524.stgit@hit-nxdomain.opendns.com> <87zkc1o63o.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zkc1o63o.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00743.txt.bz2 > Pedro> So I propose turning this warning flag on before we bit rot and pile > Pedro> up another set of problems. > > Pedro> It's likely that on other hosts we will see other related build > Pedro> failures, but going ahead and turning this on is the only way we will > Pedro> ever get those fixed, and, any build error this causes should be quite > Pedro> trivial to fix, as can be inferred from the changes in this series. > > I agree. I'm definitely in favor of this; and I think your series shows > nicely the benefits of this switch. Seconded. -- Joel