From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8881 invoked by alias); 29 Feb 2012 16:21:49 -0000 Received: (qmail 8871 invoked by uid 22791); 29 Feb 2012 16:21:47 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 16:21:29 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1TGLT1R022977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Feb 2012 11:21:29 -0500 Received: from hit-nxdomain.opendns.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1TGLR0B006489 for ; Wed, 29 Feb 2012 11:21:28 -0500 Subject: [PATCH 14/14] -Wmissing-prototypes: Build with -Wmissing-prototypes by default. To: gdb-patches@sourceware.org From: Pedro Alves Date: Wed, 29 Feb 2012 16:44:00 -0000 Message-ID: <20120229162127.23918.7524.stgit@hit-nxdomain.opendns.com> In-Reply-To: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> User-Agent: StGit/0.15 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00713.txt.bz2 An x86_64 Fedora --enable-targets=all build finishes successfuly with this. So I propose turning this warning flag on before we bit rot and pile up another set of problems. It's likely that on other hosts we will see other related build failures, but going ahead and turning this on is the only way we will ever get those fixed, and, any build error this causes should be quite trivial to fix, as can be inferred from the changes in this series. 2012-02-29 Pedro Alves * configure.ac (build_warnings): Add -Wmissing-prototypes. * configure: Regenerate. --- gdb/configure | 2 +- gdb/configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/configure b/gdb/configure index 49e9cd8..22343f5 100755 --- a/gdb/configure +++ b/gdb/configure @@ -15137,7 +15137,7 @@ fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wformat-nonliteral -Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ --Wno-switch -Wno-char-subscripts" +-Wno-switch -Wno-char-subscripts -Wmissing-prototypes" # Enable -Wno-format by default when using gcc on mingw since many # GCC versions complain about %I64. diff --git a/gdb/configure.ac b/gdb/configure.ac index fbe7d4d..e8de55c 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1795,7 +1795,7 @@ fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wformat-nonliteral -Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ --Wno-switch -Wno-char-subscripts" +-Wno-switch -Wno-char-subscripts -Wmissing-prototypes" # Enable -Wno-format by default when using gcc on mingw since many # GCC versions complain about %I64.