From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6246 invoked by alias); 29 Feb 2012 16:19:53 -0000 Received: (qmail 6235 invoked by uid 22791); 29 Feb 2012 16:19:50 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 16:19:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1TGJaOU021213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Feb 2012 11:19:36 -0500 Received: from [67.215.77.132] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1TGItac011070 for ; Wed, 29 Feb 2012 11:19:36 -0500 Subject: [PATCH 08/14] -Wmissing-prototypes: The find_and_open_source hack. To: gdb-patches@sourceware.org From: Pedro Alves Date: Wed, 29 Feb 2012 16:20:00 -0000 Message-ID: <20120229161855.23918.64481.stgit@hit-nxdomain.opendns.com> In-Reply-To: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> User-Agent: StGit/0.15 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00710.txt.bz2 $ make WERROR_CFLAGS="-Wmissing-prototypes" source.o psymtab.o 1>/dev/null ../../src/gdb/source.c:995:1: warning: no previous prototype for ‘find_and_open_source’ [-Wmissing-prototypes] Another case of a function declaration appearing in a module that uses the function, instead of in a proper header. 2012-02-29 Pedro Alves * psymtab.c (find_and_open_source): Delete declaration. * source.c (find_and_open_source): Move comment ... * source.h (find_and_open_source): ... to this new declaration. --- gdb/psymtab.c | 4 ---- gdb/source.c | 20 -------------------- gdb/source.h | 23 +++++++++++++++++++++++ 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/gdb/psymtab.c b/gdb/psymtab.c index e42545b..f894028 100644 --- a/gdb/psymtab.c +++ b/gdb/psymtab.c @@ -1131,10 +1131,6 @@ map_symbol_filenames_psymtab (struct objfile *objfile, } } -int find_and_open_source (const char *filename, - const char *dirname, - char **fullname); - /* Finds the fullname that a partial_symtab represents. If this functions finds the fullname, it will save it in ps->fullname diff --git a/gdb/source.c b/gdb/source.c index 909f252..cfdf81b 100644 --- a/gdb/source.c +++ b/gdb/source.c @@ -971,26 +971,6 @@ rewrite_source_path (const char *path) return new_path; } -/* This function is capable of finding the absolute path to a - source file, and opening it, provided you give it a FILENAME. Both the - DIRNAME and FULLNAME are only added suggestions on where to find the file. - - FILENAME should be the filename to open. - DIRNAME is the compilation directory of a particular source file. - Only some debug formats provide this info. - FULLNAME can be the last known absolute path to the file in question. - Space for the path must have been malloc'd. If a path substitution - is applied we free the old value and set a new one. - - On Success - A valid file descriptor is returned (the return value is positive). - FULLNAME is set to the absolute path to the file just opened. - The caller is responsible for freeing FULLNAME. - - On Failure - An invalid file descriptor is returned (the return value is negative). - FULLNAME is set to NULL. */ - int find_and_open_source (const char *filename, const char *dirname, diff --git a/gdb/source.h b/gdb/source.h index 3ee8e53..bf9a688 100644 --- a/gdb/source.h +++ b/gdb/source.h @@ -21,6 +21,29 @@ struct symtab; +/* This function is capable of finding the absolute path to a + source file, and opening it, provided you give it a FILENAME. Both the + DIRNAME and FULLNAME are only added suggestions on where to find the file. + + FILENAME should be the filename to open. + DIRNAME is the compilation directory of a particular source file. + Only some debug formats provide this info. + FULLNAME can be the last known absolute path to the file in question. + Space for the path must have been malloc'd. If a path substitution + is applied we free the old value and set a new one. + + On Success + A valid file descriptor is returned (the return value is positive). + FULLNAME is set to the absolute path to the file just opened. + The caller is responsible for freeing FULLNAME. + + On Failure + An invalid file descriptor is returned (the return value is negative). + FULLNAME is set to NULL. */ +extern int find_and_open_source (const char *filename, + const char *dirname, + char **fullname); + /* Open a source file given a symtab S. Returns a file descriptor or negative number for error. */ extern int open_source_file (struct symtab *s);