From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5089 invoked by alias); 29 Feb 2012 16:18:11 -0000 Received: (qmail 5079 invoked by uid 22791); 29 Feb 2012 16:18:09 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 16:17:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1TGHteC016915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Feb 2012 11:17:55 -0500 Received: from hit-nxdomain.opendns.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1TGHsrC010581 for ; Wed, 29 Feb 2012 11:17:55 -0500 Subject: [PATCH 05/14] -Wmissing-prototypes: The encode_actions hack. To: gdb-patches@sourceware.org From: Pedro Alves Date: Wed, 29 Feb 2012 16:18:00 -0000 Message-ID: <20120229161754.23918.59247.stgit@hit-nxdomain.opendns.com> In-Reply-To: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> User-Agent: StGit/0.15 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00707.txt.bz2 $ make WERROR_CFLAGS="-Wmissing-prototypes" tracepoint.o 1>/dev/null [...] ../../src/gdb/tracepoint.c:1581:1: warning: no previous prototype for ‘encode_actions’ [-Wmissing-prototypes] [...] This moves the declaration to the proper header... 2012-02-29 Pedro Alves * remote.c (encode_actions): Delete declaration. * tracepoint.c (encode_actions): Make extern. * tracepoint.h (encode_actions): Declare. --- gdb/remote.c | 3 --- gdb/tracepoint.c | 3 ++- gdb/tracepoint.h | 3 +++ 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gdb/remote.c b/gdb/remote.c index 2719241..baa3dda 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -69,9 +69,6 @@ /* Temp hacks for tracepoint encoding migration. */ static char *target_buf; static long target_buf_size; -/*static*/ void -encode_actions (struct breakpoint *t, struct bp_location *tloc, - char ***tdp_actions, char ***stepping_actions); /* The size to align memory write packets, when practical. The protocol does not guarantee any alignment, and gdb will generate short diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 37e1f52..824d572 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -1577,7 +1577,8 @@ encode_actions_1 (struct command_line *action, } /* Render all actions into gdb protocol. */ -/*static*/ void + +void encode_actions (struct breakpoint *t, struct bp_location *tloc, char ***tdp_actions, char ***stepping_actions) { diff --git a/gdb/tracepoint.h b/gdb/tracepoint.h index 00c4d7c..4003c66 100644 --- a/gdb/tracepoint.h +++ b/gdb/tracepoint.h @@ -238,6 +238,9 @@ void free_actions (struct breakpoint *); extern char *decode_agent_options (char *exp); +extern void encode_actions (struct breakpoint *t, struct bp_location *tloc, + char ***tdp_actions, char ***stepping_actions); + extern void validate_actionline (char **, struct breakpoint *); extern void end_actions_pseudocommand (char *args, int from_tty);