From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19430 invoked by alias); 25 Feb 2012 03:58:11 -0000 Received: (qmail 19417 invoked by uid 22791); 25 Feb 2012 03:58:10 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 25 Feb 2012 03:57:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1P3vmmd024815 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Feb 2012 22:57:48 -0500 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1P3viio022636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 24 Feb 2012 22:57:47 -0500 Date: Sat, 25 Feb 2012 05:58:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] PR server/9684: gdbserver, attach to stopped processes Message-ID: <20120225035743.GA17325@host2.jankratochvil.net> References: <20120224222127.14659.51317.stgit@hit-nxdomain.opendns.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120224222127.14659.51317.stgit@hit-nxdomain.opendns.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00600.txt.bz2 On Fri, 24 Feb 2012 23:21:27 +0100, Pedro Alves wrote: > Tested with the extended-remote board on x86_64 Fedora 16 (3.2, > doesn't need patch), and x86_64 RHEL 5.8 (2.6.18, needs patch). Looks OK to me, thanks. > + /* The process is definitely stopped. It is in a job control > + stop, unless the kernel predates the TASK_STOPPED / + > + First make sure there is a pending SIGSTOP. Since we are > + already attached, the process can not transition from stopped + > + /* Finally, resume the stopped process. This will deliver the > + SIGSTOP (or a higher priority signal, just like normal There are spaces instead of tabs. Jan