From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1240 invoked by alias); 24 Feb 2012 23:00:35 -0000 Received: (qmail 1222 invoked by uid 22791); 24 Feb 2012 23:00:33 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 23:00:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 587311C6956; Fri, 24 Feb 2012 18:00:18 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BSHKX9LTm5Oh; Fri, 24 Feb 2012 18:00:18 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 261CE1C68F1; Fri, 24 Feb 2012 18:00:18 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4868B145615; Fri, 24 Feb 2012 15:00:12 -0800 (PST) Date: Fri, 24 Feb 2012 23:22:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] PR server/9684: gdbserver, attach to stopped processes Message-ID: <20120224230012.GL2692@adacore.com> References: <20120224222127.14659.51317.stgit@hit-nxdomain.opendns.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120224222127.14659.51317.stgit@hit-nxdomain.opendns.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00596.txt.bz2 > I'm a bit ambivalent on this. I found out that this isn't actually > necessary on recent kernels (I haven't looked for the exact version or > commit that made it so) -- waitpid no longer hangs. OTOH, we still > need it on systems with not so recent kernels where support is still > well active, so I figure this may be useful to many upstream as well. FWIW, I tend to agree. If it is possibly useful to others, and it's not intrusive, it is all good reasons for the patch to go in. I took a look just to have an idea of what it's about, and it seems like a reasonably uninvasive patch... As always, I always marvel at the beautiful and informative comments that explain why we have to do all these horrible things :-). -- Joel