From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11537 invoked by alias); 24 Feb 2012 13:40:55 -0000 Received: (qmail 11523 invoked by uid 22791); 24 Feb 2012 13:40:53 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_50 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 13:40:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B40391C66B6; Fri, 24 Feb 2012 08:40:37 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Sd4AYGS4MG1Q; Fri, 24 Feb 2012 08:40:37 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 789471C674B; Fri, 24 Feb 2012 08:40:37 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 43C20145615; Fri, 24 Feb 2012 05:40:32 -0800 (PST) Date: Fri, 24 Feb 2012 13:48:00 -0000 From: Joel Brobecker To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: patch in ada-tasks needs small fix (was: "New ARI warning Fri Feb 24 01:54:10 UTC 2012") Message-ID: <20120224134032.GJ2692@adacore.com> References: <20120224015410.GA23561@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120224015410.GA23561@sourceware.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00557.txt.bz2 Hi Tristan, On Fri, Feb 24, 2012 at 01:54:10AM +0000, GDB Administrator wrote: > 5a6 > > gdb/ada-tasks.c:881: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this) > gdb/ada-tasks.c:881: if (TYPE_CODE (type) == TYPE_CODE_ARRAY && (eltype = check_typedef (TYPE_TARGET_TYPE (type))) && TYPE_CODE (eltype) == TYPE_CODE_PTR && (idxtype = check_typedef (TYPE_INDEX_TYPE (type))) && !TYPE_LOW_BOUND_UNDEFINED (idxtype) && !TYPE_HIGH_BOUND_UNDEFINED (idxtype)) This one is for us. I confess I hadn't noticed the assignments in the condition, but they are indeed. I think we can rewrite the code relatively easily without too much change in the program structure. Would you take a look at that? If you don't get to it today, then I will try to have a look at it. Thanks, -- Joel