From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1108 invoked by alias); 22 Feb 2012 14:54:08 -0000 Received: (qmail 1099 invoked by uid 22791); 22 Feb 2012 14:54:07 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Feb 2012 14:53:50 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1MErjeB007727 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 Feb 2012 09:53:45 -0500 Received: from host2.jankratochvil.net (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1MErclY012332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 22 Feb 2012 09:53:42 -0500 Date: Wed, 22 Feb 2012 14:58:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Eli Zaretskii , Mark Wielaard , Doug Evans Subject: Re: [RFA take 5] Allow setting breakpoints on inline functions (PR 10738) Message-ID: <20120222145337.GA17726@host2.jankratochvil.net> References: <20120220155848.GA5813@redhat.com> <20120220194804.GA5968@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120220194804.GA5968@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00473.txt.bz2 Hi Doug, On Mon, 20 Feb 2012 20:48:04 +0100, Jan Kratochvil wrote: > On Mon, 20 Feb 2012 16:58:49 +0100, Gary Benson wrote: > > This version of the patch has been updated to add a new command line > > option, --allow-incomplete-gdb-indexes, > > Sorry I was a bit offline, I believe such option would be OK just as a vendor > patch. with some more discussions about it Tom also shares this opinion. I think Google should just apply the provided patch downstream. Upstream/Gary should drop that --allow-incomplete-gdb-indexes option completely, incl. dropping the GDB code for backward compatibility with .gdb_index v4 and v5. Thanks, Jan